Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: content/browser/frame_host/render_frame_host_factory.h

Issue 881683002: Remove indirection for SiteInstance and RenderProcessHost from RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Charlie's review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 class FrameTree; 14 class FrameTree;
15 class FrameTreeNode; 15 class FrameTreeNode;
16 class RenderFrameHostDelegate; 16 class RenderFrameHostDelegate;
17 class RenderFrameHostImpl; 17 class RenderFrameHostImpl;
18 class RenderViewHostImpl; 18 class RenderViewHostImpl;
19 class RenderWidgetHostDelegate; 19 class RenderWidgetHostDelegate;
20 class SiteInstance;
20 21
21 // A factory for creating RenderFrameHosts. There is a global factory function 22 // A factory for creating RenderFrameHosts. There is a global factory function
22 // that can be installed for the purposes of testing to provide a specialized 23 // that can be installed for the purposes of testing to provide a specialized
23 // RenderFrameHostImpl class. 24 // RenderFrameHostImpl class.
24 class CONTENT_EXPORT RenderFrameHostFactory { 25 class CONTENT_EXPORT RenderFrameHostFactory {
25 public: 26 public:
26 // Creates a new RenderFrameHostImpl using the currently registered factory, 27 // Creates a new RenderFrameHostImpl using the currently registered factory,
27 // or a regular RenderFrameHostImpl if no factory is registered. 28 // or a regular RenderFrameHostImpl if no factory is registered.
28 static scoped_ptr<RenderFrameHostImpl> Create( 29 static scoped_ptr<RenderFrameHostImpl> Create(
30 SiteInstance* site_instance,
29 RenderViewHostImpl* render_view_host, 31 RenderViewHostImpl* render_view_host,
30 RenderFrameHostDelegate* delegate, 32 RenderFrameHostDelegate* delegate,
31 RenderWidgetHostDelegate* rwh_delegate, 33 RenderWidgetHostDelegate* rwh_delegate,
32 FrameTree* frame_tree, 34 FrameTree* frame_tree,
33 FrameTreeNode* frame_tree_node, 35 FrameTreeNode* frame_tree_node,
34 int routing_id, 36 int routing_id,
35 int flags); 37 int flags);
36 38
37 // Returns true if there is currently a globally-registered factory. 39 // Returns true if there is currently a globally-registered factory.
38 static bool has_factory() { return !!factory_; } 40 static bool has_factory() { return !!factory_; }
39 41
40 protected: 42 protected:
41 RenderFrameHostFactory() {} 43 RenderFrameHostFactory() {}
42 virtual ~RenderFrameHostFactory() {} 44 virtual ~RenderFrameHostFactory() {}
43 45
44 // You can derive from this class and specify an implementation for this 46 // You can derive from this class and specify an implementation for this
45 // function to create an alternate kind of RenderFrameHostImpl for testing. 47 // function to create an alternate kind of RenderFrameHostImpl for testing.
46 virtual scoped_ptr<RenderFrameHostImpl> CreateRenderFrameHost( 48 virtual scoped_ptr<RenderFrameHostImpl> CreateRenderFrameHost(
49 SiteInstance* site_instance,
47 RenderViewHostImpl* render_view_host, 50 RenderViewHostImpl* render_view_host,
48 RenderFrameHostDelegate* delegate, 51 RenderFrameHostDelegate* delegate,
49 RenderWidgetHostDelegate* rwh_delegate, 52 RenderWidgetHostDelegate* rwh_delegate,
50 FrameTree* frame_tree, 53 FrameTree* frame_tree,
51 FrameTreeNode* frame_tree_node, 54 FrameTreeNode* frame_tree_node,
52 int routing_id, 55 int routing_id,
53 int flags) = 0; 56 int flags) = 0;
54 57
55 // Registers a factory to be called when new RenderFrameHostImpls are created. 58 // Registers a factory to be called when new RenderFrameHostImpls are created.
56 // We have only one global factory, so there must be no factory registered 59 // We have only one global factory, so there must be no factory registered
57 // before the call. This class does NOT take ownership of the pointer. 60 // before the call. This class does NOT take ownership of the pointer.
58 static void RegisterFactory(RenderFrameHostFactory* factory); 61 static void RegisterFactory(RenderFrameHostFactory* factory);
59 62
60 // Unregister the previously registered factory. With no factory registered, 63 // Unregister the previously registered factory. With no factory registered,
61 // regular RenderFrameHostImpls will be created. 64 // regular RenderFrameHostImpls will be created.
62 static void UnregisterFactory(); 65 static void UnregisterFactory();
63 66
64 private: 67 private:
65 // The current globally registered factory. This is NULL when we should create 68 // The current globally registered factory. This is NULL when we should create
66 // regular RenderFrameHostImpls. 69 // regular RenderFrameHostImpls.
67 static RenderFrameHostFactory* factory_; 70 static RenderFrameHostFactory* factory_;
68 71
69 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostFactory); 72 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostFactory);
70 }; 73 };
71 74
72 } // namespace content 75 } // namespace content
73 76
74 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_ 77 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698