Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 881673002: Cleanup equality operator to accept any Object rather than just a SourceLocation. (Closed)

Created:
5 years, 11 months ago by Jacob
Modified:
5 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_span.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup equality operator to accept any Object rather than just a SourceLocation. BUG= R=nweiz@google.com Committed: https://github.com/dart-lang/source_span/commit/691bc67ba3521948f226eb0065c00eb1a9d8d7a0

Patch Set 1 #

Total comments: 4

Patch Set 2 : PTAL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/location.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Jacob
5 years, 11 months ago (2015-01-27 01:49:02 UTC) #2
nweiz
https://codereview.chromium.org/881673002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/881673002/diff/1/CHANGELOG.md#newcode2 CHANGELOG.md:2: * Cleanup equality operator to accept any Object rather ...
5 years, 11 months ago (2015-01-27 01:49:58 UTC) #3
Jacob
PTAL https://codereview.chromium.org/881673002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/881673002/diff/1/CHANGELOG.md#newcode2 CHANGELOG.md:2: * Cleanup equality operator to accept any Object ...
5 years, 11 months ago (2015-01-27 03:13:32 UTC) #4
nweiz
lgtm When you publish this, make sure to git tag the release.
5 years, 10 months ago (2015-01-27 20:45:51 UTC) #5
Jacob
5 years, 10 months ago (2015-01-27 23:30:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
691bc67ba3521948f226eb0065c00eb1a9d8d7a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698