Issue 881653003: Don't use internal gmock helper classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 881653003: Don't use internal gmock helper classes. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer

Modified:
5 years, 11 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Don't use internal gmock helper classes. BUG=v8:3835 LOG=n Committed: https://crrev.com/d4fd79a434186f04781da7c168fff848d9a4102d Cr-Commit-Position: refs/heads/master@{#26282}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -23 lines)			Patch
	M	testing/gmock-support.h	View		3 chunks	+6 lines, -23 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881653003/1

5 years, 11 months ago (2015-01-27 06:57:22 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-27 06:58:59 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d4fd79a434186f04781da7c168fff848d9a4102d
Cr-Commit-Position: refs/heads/master@{#26282}