Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 881603002: Adding an ALAC enum to AudioDecoderConfig (Closed)

Created:
5 years, 11 months ago by mikhal1
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding an ALAC enum to AudioDecoderConfig This CL enables using the ALAC codec within the media pipeline. This does not add ALAC support, as the ALAC codec is not part of the current build. BUG=441343 Committed: https://crrev.com/3e0fe16bc2c849c91530b0864b944bc5d736f9c7 Cr-Commit-Position: refs/heads/master@{#313654}

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : Removing test file #

Patch Set 4 : Fix compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M media/base/audio_buffer.cc View 4 chunks +17 lines, -1 line 0 comments Download
M media/base/audio_buffer_unittest.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M media/base/audio_decoder_config.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/audio_decoder_config.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/sample_format.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/sample_format.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 2 chunks +4 lines, -2 lines 0 comments Download
M media/mojo/services/media_type_converters.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
mikhal1
Please review.
5 years, 11 months ago (2015-01-26 22:28:53 UTC) #2
DaleCurtis
I see test data, but no new test? Are you going to put a test ...
5 years, 11 months ago (2015-01-26 23:19:55 UTC) #3
ddorwin
Is this one of multiple CLs? It doesn't seem to do what the first line ...
5 years, 11 months ago (2015-01-26 23:39:43 UTC) #5
mikhal1
On 2015/01/26 23:39:43, ddorwin wrote: > Is this one of multiple CLs? It doesn't seem ...
5 years, 11 months ago (2015-01-27 18:15:19 UTC) #6
DaleCurtis
lgtm
5 years, 11 months ago (2015-01-27 19:51:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881603002/40001
5 years, 10 months ago (2015-01-28 17:51:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/2705)
5 years, 10 months ago (2015-01-28 17:59:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881603002/60001
5 years, 10 months ago (2015-01-29 00:46:21 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-29 02:51:34 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 02:52:44 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3e0fe16bc2c849c91530b0864b944bc5d736f9c7
Cr-Commit-Position: refs/heads/master@{#313654}

Powered by Google App Engine
This is Rietveld 408576698