Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 881573004: [Extensions Toolbar Mac] Adjust button threshold for hiding (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar Mac] Adjust button threshold for hiding Since the toolbar frame now includes the proper padding, icons are a little too eager to show after adjusting the chevron. Make them a bit more shy again (hide them if they have >= 3px not displayed when adjusting the toolbar). BUG=452475 Committed: https://crrev.com/6fd65634b5cff0510336bd958e85234bdd3eaf57 Cr-Commit-Position: refs/heads/master@{#313730}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Please take a look when you can. :)
5 years, 10 months ago (2015-01-29 01:11:01 UTC) #3
Avi (use Gerrit)
lgtm I appreciate the polishing.
5 years, 10 months ago (2015-01-29 02:52:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881573004/20001
5 years, 10 months ago (2015-01-29 17:11:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-01-29 17:45:15 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 17:46:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fd65634b5cff0510336bd958e85234bdd3eaf57
Cr-Commit-Position: refs/heads/master@{#313730}

Powered by Google App Engine
This is Rietveld 408576698