Issue 881563002: Remove clear function from SkGPipe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 881563002: Remove clear function from SkGPipe (Closed)

Created:
5 years, 10 months ago by derekf

Modified:
5 years, 10 months ago

Reviewers:
mtklein, Justin Novosad, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Remove clear function from SkGPipe Clear no longer exists. (It's now a drawPaint call) Committed: https://skia.googlesource.com/skia/+/b041efe2a825ea94c0a3805f1f8ca635c6c69dce

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -14 lines)			Patch
	M	src/pipe/SkGPipePriv.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
	M	src/pipe/SkGPipeRead.cpp	View		2 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 7 (3 generated)

derekf

since commit f4e0d9eb2d clear() has been an alias for drawPaint. Can we remove clear from ...

5 years, 10 months ago (2015-01-26 20:46:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881563002/1

5 years, 10 months ago (2015-01-26 20:52:02 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-01-26 20:59:09 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b041efe2a825ea94c0a3805f1f8ca635c6c69dce