Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 881553003: Ignore the default zoom level for the PDF extension and print preview. (Closed)

Created:
5 years, 11 months ago by Sam McNally
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore the default zoom level for the PDF extension and print preview. Previously, the PDF extension UI was zoomed to the default zoom level and the PDF was inversely affected (due to various calculations using zoomed and not zoomed sizes). This resets the zoom level for extensions used as mime handlers on mime handler WebContents creation and for print preview (as the PDF extension zoom as controlled by the embedding print preview dialog WebContents. BUG=450910 Committed: https://crrev.com/335f3d635b8403ad2a2ec2e3a346f0436db40b46 Cr-Commit-Position: refs/heads/master@{#313444}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Sam McNally
5 years, 11 months ago (2015-01-27 23:44:25 UTC) #2
raymes
lgtm https://codereview.chromium.org/881553003/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/881553003/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode132 extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:132: content::HostZoomMap::Get(guest_site_instance) Could you add a comment about why ...
5 years, 11 months ago (2015-01-28 00:39:28 UTC) #3
Sam McNally
+vitalybuka for chrome/browser/printing/print_preview_dialog_controller.cc https://codereview.chromium.org/881553003/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/881553003/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode132 extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:132: content::HostZoomMap::Get(guest_site_instance) On 2015/01/28 00:39:28, raymes wrote: ...
5 years, 11 months ago (2015-01-28 01:35:15 UTC) #5
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 11 months ago (2015-01-28 01:40:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881553003/20001
5 years, 11 months ago (2015-01-28 01:53:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-28 04:24:06 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 04:25:47 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/335f3d635b8403ad2a2ec2e3a346f0436db40b46
Cr-Commit-Position: refs/heads/master@{#313444}

Powered by Google App Engine
This is Rietveld 408576698