Make SDCH dictionaries persistent across browser restart.

net/sdch/sdch_owner.h

Index: net/sdch/sdch_owner.h
diff --git a/net/sdch/sdch_owner.h b/net/sdch/sdch_owner.h
index 9620326118c661bedc13eb6785980520aa5171de..a087206941d8c550518233386ee5bc60bcd5e448 100644
--- a/net/sdch/sdch_owner.h
+++ b/net/sdch/sdch_owner.h
@@ -5,13 +5,18 @@
 #ifndef NET_SDCH_SDCH_OWNER_H_
 #define NET_SDCH_SDCH_OWNER_H_
 
+#include <map>
 #include <string>
 
 #include "base/memory/memory_pressure_listener.h"
+#include "base/prefs/pref_store.h"
 #include "net/base/sdch_observer.h"
 #include "net/url_request/sdch_dictionary_fetcher.h"
 
 class GURL;
+class PersistentPrefStore;
+class ValueMapPrefStore;
+class WriteablePrefStore;
 
 namespace base {
 class Clock;
@@ -25,7 +30,8 @@ class URLRequestContext;
 // exposes interface for setting SDCH policy.  It should be instantiated by
 // the net/ embedder.
 // TODO(rdsmith): Implement dictionary prioritization.
-class NET_EXPORT SdchOwner : public net::SdchObserver {
+class NET_EXPORT SdchOwner : public net::SdchObserver,
+                             public PrefStore::Observer {
  public:
   static const size_t kMaxTotalDictionarySize;
   static const size_t kMinSpaceForDictionaryFetch;
@@ -35,6 +41,13 @@ class NET_EXPORT SdchOwner : public net::SdchObserver {
   SdchOwner(net::SdchManager* sdch_manager, net::URLRequestContext* context);
   ~SdchOwner() override;
 
+  // Enables use of pref persistence.  Dictionaries added to the SdchManager
+  // before this call is made will not be added to the pref store.
+  // Note that |pref_store| is owned by the caller, but must be guaranteed
+  // to outlive SdchOwner.
+  // This routine may only be called once per SdchOwner instance.
+  void EnablePersistentStorage(PersistentPrefStore* pref_store);
+
   // Defaults to kMaxTotalDictionarySize.
   void SetMaxTotalDictionarySize(size_t max_total_dictionary_size);
 
@@ -49,11 +62,16 @@ class NET_EXPORT SdchOwner : public net::SdchObserver {
                        const GURL& dictionary_url) override;
   void OnClearDictionaries(net::SdchManager* manager) override;
 
+  // PrefStore::Observer implementation.
+  void OnPrefValueChanged(const std::string& key) override;
+  void OnInitializationCompleted(bool succeeded) override;
+
   // Implementation detail--this is the pathway through which the
   // fetcher informs the SdchOwner that it's gotten the dictionary.
   // Public for testing.
   void OnDictionaryFetched(const std::string& dictionary_text,
                            const GURL& dictionary_url,
+                           scoped_ptr<SdchDictionaryFetcher::Data> extra_data,
                            const net::BoundNetLog& net_log);
 
   void SetClockForTesting(scoped_ptr<base::Clock> clock);
@@ -76,6 +94,9 @@ class NET_EXPORT SdchOwner : public net::SdchObserver {
   void OnMemoryPressure(
       base::MemoryPressureListener::MemoryPressureLevel level);
 
+  // Returns false if the load fails for some reason.
+  bool LoadPersistedDictionaries(const base::DictionaryValue& persisted_info);

[mmenke, 2015/02/02 16:35:28]

These needs a lot more detail, and maybe a rename, because of how it works -
scheduling fetches, rather than loading them into a pref store directly isn't
terribly intuitive.

[Randy Smith (Not in Mondays), 2015/02/04 19:29:03]

I've rewritten the comment and renamed the function; let me know what you think.

+
   net::SdchManager* manager_;
   net::SdchDictionaryFetcher fetcher_;
 
@@ -87,6 +108,17 @@ class NET_EXPORT SdchOwner : public net::SdchObserver {
   size_t max_total_dictionary_size_;
   size_t min_space_for_dictionary_fetch_;
 
+  // Dictionary persistence machinery.  |in_memory_pref_store_|
+  // is created on construction and used in the absence of any call
+  // to EnablePersistentStorage().  |persistent_pref_store_| holds the
+  // preference store specified by EnablePersistentStorage() (if any).
+  // |pref_store_| is shifted from the first to the second after the
+  // persistent pref store information is fully read in.
+  scoped_refptr<ValueMapPrefStore> in_memory_pref_store_;
+  PersistentPrefStore* persistent_pref_store_;
+
+  WriteablePrefStore* pref_store_;
+
   base::MemoryPressureListener memory_pressure_listener_;
 
   DISALLOW_COPY_AND_ASSIGN(SdchOwner);