Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: pkg/compiler/lib/src/js_emitter/model.dart

Issue 881363006: Store the aliasName of a method in the model. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/model.dart
diff --git a/pkg/compiler/lib/src/js_emitter/model.dart b/pkg/compiler/lib/src/js_emitter/model.dart
index 29b547c560d068814f71081f4704cff97a0d685c..f6d3e1b5200d626cecd5c4f68b12faa298ca1dce 100644
--- a/pkg/compiler/lib/src/js_emitter/model.dart
+++ b/pkg/compiler/lib/src/js_emitter/model.dart
@@ -316,7 +316,6 @@ class DartMethod extends Method {
final String tearOffName;
// TODO(herhut): Directly store stubs instead/
final bool needsStubs;
- // TODO(herhut): Directly store aliases instead.
final bool canBeApplied;
DartMethod(Element element, String name, js.Expression code,
@@ -330,14 +329,13 @@ class DartMethod extends Method {
}
class InstanceMethod extends DartMethod {
- // TODO(herhut): Directly store aliases instead.
- final bool hasSuperAlias;
+ final String aliasName;
floitsch 2015/01/29 15:24:35 Add documentation what this is. When does it happe
herhut 2015/02/03 10:20:16 Done.
final bool isClosure;
InstanceMethod(element, name, code,
{bool needsTearOff,
String tearOffName,
- this.hasSuperAlias,
+ this.aliasName,
bool canBeApplied,
this.isClosure,
bool needsStubs})
@@ -346,7 +344,6 @@ class InstanceMethod extends DartMethod {
tearOffName: tearOffName,
canBeApplied: canBeApplied,
needsStubs: needsStubs) {
- assert(hasSuperAlias != null);
assert(isClosure != null);
}
}

Powered by Google App Engine
This is Rietveld 408576698