Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc

Issue 881353002: Revert of Dump property values for the touch log source (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/events/ozone/evdev/input_controller_evdev.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc
diff --git a/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc b/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc
index 078b692ee0a62ff3bcf2c38ddabecc91883906a4..3e9f16524ca3b09afa34f637be703fbd256ced40 100644
--- a/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc
+++ b/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc
@@ -6,17 +6,12 @@
#include "ash/touch/touch_hud_debug.h"
#include "base/bind.h"
-#include "base/bind_helpers.h"
-#include "base/callback.h"
#include "base/command_line.h"
#include "base/json/json_string_value_serializer.h"
#include "base/logging.h"
-#include "base/message_loop/message_loop.h"
#include "base/process/launch.h"
#include "components/feedback/feedback_util.h"
#include "content/public/browser/browser_thread.h"
-#include "ui/ozone/public/input_controller.h"
-#include "ui/ozone/public/ozone_platform.h"
using content::BrowserThread;
@@ -24,26 +19,7 @@
const char kHUDLogDataKey[] = "hud_log";
-// The prefix "hack-33025" was historically chosen in http://crbug.com/139715.
-// We continue to go with it in order to be compatible with the existing touch
-// log processing toolchain.
-const char kDeviceStatusLogDataKey[] = "hack-33025-touchpad";
-
-// Callback for handing the outcome of GetTouchDeviceStatus(). Appends the
-// collected log to the SystemLogsResponse map.
-void OnStatusLogCollected(scoped_ptr<system_logs::SystemLogsResponse> response,
- const system_logs::SysLogsSourceCallback& callback,
- scoped_ptr<std::string> log) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- (*response)[kDeviceStatusLogDataKey] = *log;
-
- BrowserThread::PostTask(
- BrowserThread::UI, FROM_HERE,
- base::Bind(callback, base::Owned(response.release())));
-}
-
-// Collect touch HUD debug logs. This needs to be done on the UI thread.
-void CollectTouchHudDebugLog(system_logs::SystemLogsResponse* response) {
+void GetTouchLogsOzone(system_logs::SystemLogsResponse* response) {
scoped_ptr<base::DictionaryValue> dictionary =
ash::TouchHudDebug::GetAllAsDictionary();
if (!dictionary->empty()) {
@@ -53,6 +29,10 @@
if (json.Serialize(*dictionary) && !touch_log.empty())
(*response)[kHUDLogDataKey] = touch_log;
}
+
+ // TODO(sheckylin): Add ozone touch log collection implementation. See
+ // http://crbug.com/400022.
+ NOTIMPLEMENTED();
}
} // namespace
@@ -63,12 +43,10 @@
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!callback.is_null());
- scoped_ptr<SystemLogsResponse> response(new SystemLogsResponse);
- CollectTouchHudDebugLog(response.get());
-
- // Collect touch device status logs.
- ui::OzonePlatform::GetInstance()->GetInputController()->GetTouchDeviceStatus(
- base::Bind(&OnStatusLogCollected, base::Passed(&response), callback));
+ SystemLogsResponse* response = new SystemLogsResponse;
+ BrowserThread::PostBlockingPoolTaskAndReply(
+ FROM_HERE, base::Bind(&GetTouchLogsOzone, response),
+ base::Bind(callback, base::Owned(response)));
}
} // namespace system_logs
« no previous file with comments | « no previous file | ui/events/ozone/evdev/input_controller_evdev.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698