Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 881353002: Revert of Dump property values for the touch log source (Closed)

Created:
5 years, 10 months ago by James Cook
Modified:
5 years, 10 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, nkostylev+watch_chromium.org, tdresser+watch_chromium.org, jdduke+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Dump property values for the touch log source (patchset #11 id:200001 of https://codereview.chromium.org/864253002/) Reason for revert: Broke the arm-generic-freon builder on Chrome OS: https://uberchromegw.corp.google.com/i/chromeos/builders/arm-generic_freon%20nightly%20chromium%20PFQ/builds/549/steps/BuildPackages/logs/stdio See crbug.com/452911 - looks like a printf format specifier is wrong on 32 bit Original issue's description: > Dump property values for the touch log source > > The CL dumps gesture property values for touch devices that run > with the CrOS gesture library. The format is designed to be > backward-compatible with the X11 behaviour. > > Contributed by sheckylin@chromium.org > > BUG=450159 > TEST=samus ChromeOS build > > Committed: https://crrev.com/8b1fb4fdf2b13b71e969cd541e500549163f742b > Cr-Commit-Position: refs/heads/master@{#313446} TBR=achuith@chromium.org,spang@chromium.org,alexst@chromium.org,adlr@chromium.org,miletus@chromium.org,sheckylin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450159 Committed: https://crrev.com/eb9408f5daada4b3929411ea7dffa8d60db3bbaf Cr-Commit-Position: refs/heads/master@{#313522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -163 lines) Patch
M chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc View 4 chunks +9 lines, -31 lines 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.cc View 3 chunks +0 lines, -86 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/ozone/public/input_controller.h View 3 chunks +0 lines, -8 lines 0 comments Download
M ui/ozone/public/input_controller.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Created Revert of Dump property values for the touch log source
5 years, 10 months ago (2015-01-28 16:25:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881353002/1
5 years, 10 months ago (2015-01-28 16:26:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 16:27:42 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 16:28:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb9408f5daada4b3929411ea7dffa8d60db3bbaf
Cr-Commit-Position: refs/heads/master@{#313522}

Powered by Google App Engine
This is Rietveld 408576698