Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: src/ppc/full-codegen-ppc.cc

Issue 881303002: [turbofan] Add missing deopt for the assignment in the for-in statement. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/full-codegen-mips64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_PPC 7 #if V8_TARGET_ARCH_PPC
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1199 matching lines...) Expand 10 before | Expand all | Expand 10 after
1210 __ beq(loop_statement.continue_label()); 1210 __ beq(loop_statement.continue_label());
1211 1211
1212 // Update the 'each' property or variable from the possibly filtered 1212 // Update the 'each' property or variable from the possibly filtered
1213 // entry in register r6. 1213 // entry in register r6.
1214 __ bind(&update_each); 1214 __ bind(&update_each);
1215 __ mr(result_register(), r6); 1215 __ mr(result_register(), r6);
1216 // Perform the assignment as if via '='. 1216 // Perform the assignment as if via '='.
1217 { 1217 {
1218 EffectContext context(this); 1218 EffectContext context(this);
1219 EmitAssignment(stmt->each()); 1219 EmitAssignment(stmt->each());
1220 PrepareForBailoutForId(stmt->AssignmentId(), NO_REGISTERS);
1220 } 1221 }
1221 1222
1222 // Generate code for the body of the loop. 1223 // Generate code for the body of the loop.
1223 Visit(stmt->body()); 1224 Visit(stmt->body());
1224 1225
1225 // Generate code for the going to the next element by incrementing 1226 // Generate code for the going to the next element by incrementing
1226 // the index (smi) stored on top of the stack. 1227 // the index (smi) stored on top of the stack.
1227 __ bind(loop_statement.continue_label()); 1228 __ bind(loop_statement.continue_label());
1228 __ pop(r3); 1229 __ pop(r3);
1229 __ AddSmiLiteral(r3, r3, Smi::FromInt(1), r0); 1230 __ AddSmiLiteral(r3, r3, Smi::FromInt(1), r0);
(...skipping 4053 matching lines...) Expand 10 before | Expand all | Expand 10 after
5283 return ON_STACK_REPLACEMENT; 5284 return ON_STACK_REPLACEMENT;
5284 } 5285 }
5285 5286
5286 DCHECK(interrupt_address == 5287 DCHECK(interrupt_address ==
5287 isolate->builtins()->OsrAfterStackCheck()->entry()); 5288 isolate->builtins()->OsrAfterStackCheck()->entry());
5288 return OSR_AFTER_STACK_CHECK; 5289 return OSR_AFTER_STACK_CHECK;
5289 } 5290 }
5290 } 5291 }
5291 } // namespace v8::internal 5292 } // namespace v8::internal
5292 #endif // V8_TARGET_ARCH_PPC 5293 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/mips64/full-codegen-mips64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698