Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 881263002: DevTools: use target-based model accessors only. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 */ 262 */
263 setHeight: function(height) 263 setHeight: function(height)
264 { 264 {
265 this.bodyElement.style.height = height; 265 this.bodyElement.style.height = height;
266 }, 266 },
267 267
268 /** 268 /**
269 * @param {string} title 269 * @param {string} title
270 * @param {function(?string=)} callback 270 * @param {function(?string=)} callback
271 * @param {?Protocol.Error} error 271 * @param {?Protocol.Error} error
272 * @param {!RuntimeAgent.RemoteObject} result 272 * @param {?WebInspector.RemoteObject} result
273 * @param {boolean=} wasThrown 273 * @param {boolean=} wasThrown
274 */ 274 */
275 _onEvaluate: function(title, callback, error, result, wasThrown) 275 _onEvaluate: function(title, callback, error, result, wasThrown)
276 { 276 {
277 if (error) 277 if (error)
278 callback(error.toString()); 278 callback(error.toString());
279 else 279 else
280 this._setObject(WebInspector.runtimeModel.createRemoteObject(result) , title, callback); 280 this._setObject(/** @type {!WebInspector.RemoteObject} */ (result), title, callback);
281 }, 281 },
282 282
283 _createObjectPropertiesView: function() 283 _createObjectPropertiesView: function()
284 { 284 {
285 if (this._objectPropertiesView) 285 if (this._objectPropertiesView)
286 return; 286 return;
287 if (this._extensionView) { 287 if (this._extensionView) {
288 this._extensionView.detach(true); 288 this._extensionView.detach(true);
289 delete this._extensionView; 289 delete this._extensionView;
290 } 290 }
(...skipping 18 matching lines...) Expand all
309 if (!title) 309 if (!title)
310 section.headerElement.classList.add("hidden"); 310 section.headerElement.classList.add("hidden");
311 section.expand(); 311 section.expand();
312 section.editable = false; 312 section.editable = false;
313 this._objectPropertiesView.element.appendChild(section.element); 313 this._objectPropertiesView.element.appendChild(section.element);
314 callback(); 314 callback();
315 }, 315 },
316 316
317 __proto__: WebInspector.SidebarPane.prototype 317 __proto__: WebInspector.SidebarPane.prototype
318 } 318 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | Source/devtools/front_end/extensions/ExtensionServer.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698