build/config/BUILD.gn - Issue 881213004: Support building BoringSSL with NSS certificates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILD.gn

Issue 881213004: Support building BoringSSL with NSS certificates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sleevi comments, various build and test fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILD.gn

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn

index 49b5cfeb6a58ca05cd1c7395d1c67343888ba39a..e98e9f5b96f0c2a6a73e95b28107d36510d137c4 100644

--- a/build/config/BUILD.gn

+++ b/build/config/BUILD.gn

@@ -114,10 +114,11 @@ config("feature_flags") {

}

if (use_openssl) {

defines += [ "USE_OPENSSL=1" ]

- if (use_openssl_certs) {

- defines += [ "USE_OPENSSL_CERTS=1" ]

- }

- } else if (use_nss_certs) {

+ }

+ if (use_openssl_certs) {

+ defines += [ "USE_OPENSSL_CERTS=1" ]

+ }

+ if (use_nss_certs) {

# USE_NSS really means "use nss for certificate validation and storage"

# (like USE_OPENSSL_CERTS) and not "we're linking to NSS." It might be nice

# to rename this but we're hoping to transition away from NSS.