crypto/rsa_private_key_unittest.cc - Issue 881213004: Support building BoringSSL with NSS certificates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/rsa_private_key_unittest.cc

Issue 881213004: Support building BoringSSL with NSS certificates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly tidier (edit: looks like this'll need a rebase later for try jobs to run.) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: crypto/rsa_private_key_unittest.cc

diff --git a/crypto/rsa_private_key_unittest.cc b/crypto/rsa_private_key_unittest.cc

index cbc3799843dc8d6253c67d0fdb4bd0c9a4a83782..b231cac6cc3110fa1fd231b65e1851c267193c52 100644

--- a/crypto/rsa_private_key_unittest.cc

+++ b/crypto/rsa_private_key_unittest.cc

@@ -445,9 +445,6 @@ TEST(RSAPrivateKeyUnitTest, ShortIntegers) {

input2.size()));

}

-// The following test can run if either USE_NSS or USE_OPENSSL is defined, but

-// not otherwise (since it uses crypto::RSAPrivateKey::CreateFromKey).

-#if defined(USE_NSS) || defined(USE_OPENSSL)

TEST(RSAPrivateKeyUnitTest, CreateFromKeyTest) {

scoped_ptr<crypto::RSAPrivateKey> key_pair(

crypto::RSAPrivateKey::Create(256));

@@ -469,5 +466,4 @@ TEST(RSAPrivateKeyUnitTest, CreateFromKeyTest) {

ASSERT_EQ(privkey, privkey_copy);

ASSERT_EQ(pubkey, pubkey_copy);

}

-#endif