content/child/webcrypto/test/test_helpers.cc - Issue 881213004: Support building BoringSSL with NSS certificates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/test/test_helpers.cc

Issue 881213004: Support building BoringSSL with NSS certificates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly tidier (edit: looks like this'll need a rebase later for try jobs to run.) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/webcrypto/test/test_helpers.cc

diff --git a/content/child/webcrypto/test/test_helpers.cc b/content/child/webcrypto/test/test_helpers.cc

index 538a7d686402b9688e0727ec400171122b0928a1..1a4ea91deb4eb9c28357132344d6031aaed1123d 100644

--- a/content/child/webcrypto/test/test_helpers.cc

+++ b/content/child/webcrypto/test/test_helpers.cc

@@ -127,7 +127,7 @@ bool SupportsRsaOaep() {

bool SupportsRsaPrivateKeyImport() {

// TODO(eroman): Exclude version test for OS_CHROMEOS

-#if defined(USE_NSS)

+#if !defined(USE_OPENSSL) && defined(USE_NSS)

crypto::EnsureNSSInit();

if (!NSS_VersionCheck("3.16.2")) {

LOG(WARNING) << "RSA key import is not supported by this version of NSS. "