Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 881203003: Suppress sequence checks in SyncFileSystem on the shutdown phase (Closed)

Created:
5 years, 10 months ago by tzik
Modified:
5 years, 10 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress sequence checks in SyncFileSystem on the shutdown phase SyncFileSystem stuff hits DCHECK or NOTREACHED on shutdown phase. That is due to failing PostTask() SequencedWorkerPool. This CL relaxes several assertions in the case. * Disable TaskToken tracking if SequencedWorkerPool is being shut down. * Leak SyncWorker if SequencedWorkerPool is being shut down, instead of deleting it in the other thread. BUG=453226 Committed: https://crrev.com/3ad68aba0b036b9eb2c67738c83c8dfed1fe6fe5 Cr-Commit-Position: refs/heads/master@{#314503}

Patch Set 1 #

Patch Set 2 : +param comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -56 lines) Patch
M chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 6 chunks +9 lines, -25 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.h View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.h View 4 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc View 1 7 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_token.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tzik
PTAL
5 years, 10 months ago (2015-02-03 06:52:53 UTC) #2
nhiroki
lgtm
5 years, 10 months ago (2015-02-04 03:37:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881203003/20001
5 years, 10 months ago (2015-02-04 03:50:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 04:17:06 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 04:18:11 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ad68aba0b036b9eb2c67738c83c8dfed1fe6fe5
Cr-Commit-Position: refs/heads/master@{#314503}

Powered by Google App Engine
This is Rietveld 408576698