ppapi/proxy/udp_socket_resource_base.cc - Issue 881203002: Fix callback access in Pepper's UDP socket resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/udp_socket_resource_base.cc

Issue 881203002: Fix callback access in Pepper's UDP socket resource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/udp_socket_resource_base.cc

diff --git a/ppapi/proxy/udp_socket_resource_base.cc b/ppapi/proxy/udp_socket_resource_base.cc

index b5c977c3a094a2df67f2cc44892a5a33e10150c2..0e4b083f1ed905fe4f1ef09a4c3cbe3f92c7f683 100644

--- a/ppapi/proxy/udp_socket_resource_base.cc

+++ b/ppapi/proxy/udp_socket_resource_base.cc

@@ -320,6 +320,9 @@ void UDPSocketResourceBase::OnPluginMsgPushRecvResult(

void UDPSocketResourceBase::OnPluginMsgSendToReply(

const ResourceMessageReplyParams& params,

int32_t bytes_written) {

+ if (sendto_callbacks_.empty())

bbudge 2015/01/28 18:07:31 Add a comment that this could happen when the sock

+ return;

scoped_refptr<TrackedCallback> callback = sendto_callbacks_.front();

sendto_callbacks_.pop();

if (!TrackedCallback::IsPending(callback))

« no previous file with comments | « no previous file | no next file » | no next file with comments »