Source/core/animation/AnimationEffect.h - Issue 881183003: Animation: Cancel same-property animations on compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimationEffect.h

Issue 881183003: Animation: Cancel same-property animations on compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add manual test. Improve code a bit. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/AnimationEffect.h

diff --git a/Source/core/animation/AnimationEffect.h b/Source/core/animation/AnimationEffect.h

index fd487a314a413b66fe18351fd288f8eb096d2963..9ef1aeaeb9e53fec8552201a3714eff551788444 100644

--- a/Source/core/animation/AnimationEffect.h

+++ b/Source/core/animation/AnimationEffect.h

@@ -54,7 +54,7 @@ public:

virtual ~AnimationEffect() { }

virtual void sample(int iteration, double fraction, double iterationDuration, OwnPtrWillBeRawPtr<WillBeHeapVector<RefPtrWillBeMember<Interpolation>>>&) const = 0;

- virtual bool affects(CSSPropertyID) { return false; };

+ virtual bool affects(CSSPropertyID) const { return false; };

virtual bool isKeyframeEffectModel() const { return false; }

virtual void trace(Visitor*) { }

« no previous file with comments | « Source/core/animation/Animation.cpp ('k') | Source/core/animation/AnimationPlayer.h » ('j') | no next file with comments »