Animation: Cancel same-property animations on compositor

Source/core/animation/CompositorAnimations.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/animation/CompositorAnimations.h"
 
+#include "core/animation/ActiveAnimations.h"
 #include "core/animation/AnimationNode.h"
 #include "core/animation/AnimationTranslationUtil.h"
 #include "core/animation/CompositorAnimationsImpl.h"
 #include "core/animation/animatable/AnimatableDouble.h"
 #include "core/animation/animatable/AnimatableFilterOperations.h"
 #include "core/animation/animatable/AnimatableTransform.h"
 #include "core/animation/animatable/AnimatableValue.h"
 #include "core/rendering/RenderBoxModelObject.h"
 #include "core/rendering/RenderLayer.h"
 #include "core/rendering/RenderObject.h"
@@ skipping 19 matching lines @@
 void getKeyframeValuesForProperty(const KeyframeEffectModelBase* effect, CSSPropertyID id, double scale, PropertySpecificKeyframeVector& values)
 {
     ASSERT(values.isEmpty());
 
     for (const auto& keyframe : effect->getPropertySpecificKeyframes(id)) {
         double offset = keyframe->offset() * scale;
         values.append(keyframe->cloneWithOffset(offset));
     }
 }
 
+bool alreadyActiveAnimationsBlockProperties(const Element& targetElement, const AnimationPlayer& playerToAdd, const AnimationEffect& effectToAdd)

[dstockwell, 2015/01/28 05:44:05]

I think this would be better written as:

bool affectsOpacity = effectToAdd.affects(CSSPropertyOpacity);

... for ...
  if (affectsOpacity && attachedPlayer->affects(...Opacity))
    return true;

return false;


Also the name is hard, if we went with 'incompatible' it could be just
'hasIncompatatibleAnimations'

[loyso (OOO), 2015/01/28 06:33:31]

Good point. That's also will be more efficient. 
That's more generic but good. Thanks!

+{
+    bool propertyOpacityBlocked = false;
+    bool propertyTransformBlocked = false;
+    bool propertyFilterBlocked = false;
+
+    if (targetElement.hasActiveAnimations()) {
+        ActiveAnimations* activeAnimations = targetElement.activeAnimations();
+        ASSERT(activeAnimations);
+
+        for (const auto& entry : activeAnimations->players()) {
+            const AnimationPlayer* attachedPlayer = entry.key;

[dstockwell, 2015/01/28 05:44:05]

Is it possible to skip consideration of earlier players which are filling?

[loyso (OOO), 2015/01/29 01:08:54]

What do you mean? Players with fill=forwards will be in
activeAnimations().players(), I suppose.

[dstockwell, 2015/01/29 01:14:07]

Yes. Hmm, also players which are idle or finished will be in the list.

[loyso (OOO), 2015/01/29 04:35:59]

Is that a problem? Should we address it?

+            if (attachedPlayer == &playerToAdd)
+                continue;
+
+            if (attachedPlayer->affects(CSSPropertyOpacity))
+                propertyOpacityBlocked = true;
+            else if (attachedPlayer->affects(CSSPropertyTransform))
+                propertyTransformBlocked = true;
+            else if (attachedPlayer->affects(CSSPropertyWebkitFilter))
+                propertyFilterBlocked = true;
+        }
+    }
+
+    if ((propertyOpacityBlocked && effectToAdd.affects(CSSPropertyOpacity))
+        || (propertyTransformBlocked && effectToAdd.affects(CSSPropertyTransform))
+        || (propertyFilterBlocked && effectToAdd.affects(CSSPropertyWebkitFilter)))
+        return true;
+
+    return false;
+}
 }
 
 bool CompositorAnimations::getAnimatedBoundingBox(FloatBox& box, const AnimationEffect& effect, double minValue, double maxValue) const
 {
     const KeyframeEffectModelBase& keyframeEffect = toKeyframeEffectModelBase(effect);
 
     PropertySet properties = keyframeEffect.properties();
 
     if (properties.isEmpty())
         return true;
@@ skipping 43 matching lines @@
             box.expandTo(bounds);
         }
     }
     return true;
 }
 
 // -----------------------------------------------------------------------
 // CompositorAnimations public API
 // -----------------------------------------------------------------------
 
-bool CompositorAnimations::isCandidateForAnimationOnCompositor(const Timing& timing, const AnimationEffect& effect, double playerPlaybackRate)
+bool CompositorAnimations::isCandidateForAnimationOnCompositor(const Timing& timing, const Element* targetElement, const AnimationPlayer* playerToAdd, const AnimationEffect& effect, double playerPlaybackRate)

[dstockwell, 2015/01/28 05:44:05]

When can targetElement be null?

[loyso (OOO), 2015/01/28 06:33:31]

Unit tests. I could setup a fake one there if we need the reference type badly.

[loyso (OOO), 2015/01/28 23:18:34]

Do we need it?

[dstockwell, 2015/01/29 01:14:07]

Unless it's non-trivial to create an Element in the test I think we should
prefer targetElement to be non-nullable.

 {
+    if (targetElement && playerToAdd && alreadyActiveAnimationsBlockProperties(*targetElement, *playerToAdd, effect))
+        return false;
+
     const KeyframeEffectModelBase& keyframeEffect = toKeyframeEffectModelBase(effect);
 
     PropertySet properties = keyframeEffect.properties();
-
     if (properties.isEmpty())
         return false;
 
     for (const auto& property : properties) {
         const PropertySpecificKeyframeVector& keyframes = keyframeEffect.getPropertySpecificKeyframes(property);
         ASSERT(keyframes.size() >= 2);
         for (const auto& keyframe : keyframes) {
             // FIXME: Determine candidacy based on the CSSValue instead of a snapshot AnimatableValue.
             if (keyframe->composite() != AnimationEffect::CompositeReplace || !keyframe->getAnimatableValue())
                 return false;
 
             switch (property) {
             case CSSPropertyOpacity:
                 break;
             case CSSPropertyTransform:
                 if (toAnimatableTransform(keyframe->getAnimatableValue().get())->transformOperations().dependsOnBoxSize())
                     return false;
                 break;
             case CSSPropertyWebkitFilter: {
                 const FilterOperations& operations = toAnimatableFilterOperations(keyframe->getAnimatableValue().get())->operations();
                 if (operations.hasFilterThatMovesPixels())
                     return false;
                 break;
             }
             default:
+                // any other types are not allowed to run on compositor.
                 return false;
             }
         }
     }
 
     CompositorAnimationsImpl::CompositorTiming out;
     if (!CompositorAnimationsImpl::convertTimingForCompositor(timing, 0, out, playerPlaybackRate))
         return false;
 
     return true;
 }
 
+void CompositorAnimations::cancelAffectedAnimationsOnCompositor(const Element& targetElement, const AnimationPlayer& playerToAdd, const AnimationEffect& effectToAdd)
+{
+    const bool propertyOpacityCancel = effectToAdd.affects(CSSPropertyOpacity);
+    const bool propertyTransformCancel = effectToAdd.affects(CSSPropertyTransform);
+    const bool propertyFilterCancel = effectToAdd.affects(CSSPropertyWebkitFilter);
+
+    if (!targetElement.hasActiveAnimations())
+        return;
+
+    ActiveAnimations* activeAnimations = targetElement.activeAnimations();
+    ASSERT(activeAnimations);
+
+    for (const auto& entry : activeAnimations->players()) {
+        AnimationPlayer* attachedPlayer = entry.key;
+        if (attachedPlayer == &playerToAdd)
+            continue;
+
+        if ((propertyOpacityCancel && attachedPlayer->affects(CSSPropertyOpacity))
+            || (propertyTransformCancel && attachedPlayer->affects(CSSPropertyTransform))
+            || (propertyFilterCancel && attachedPlayer->affects(CSSPropertyWebkitFilter)))
+            attachedPlayer->cancelAnimationOnCompositor();
+    }
+}
+
 bool CompositorAnimations::canStartAnimationOnCompositor(const Element& element)
 {
     return element.renderer() && element.renderer()->compositingState() == PaintsIntoOwnBacking;
 }
 
-bool CompositorAnimations::startAnimationOnCompositor(const Element& element, int group, double startTime, double timeOffset, const Timing& timing, const AnimationEffect& effect, Vector<int>& startedAnimationIds, double playerPlaybackRate)
+bool CompositorAnimations::startAnimationOnCompositor(const Element& element, int group, double startTime, double timeOffset, const Timing& timing, const AnimationPlayer* player, const AnimationEffect& effect, Vector<int>& startedAnimationIds, double playerPlaybackRate)
 {
     ASSERT(startedAnimationIds.isEmpty());
-    ASSERT(isCandidateForAnimationOnCompositor(timing, effect, playerPlaybackRate));
+    ASSERT(isCandidateForAnimationOnCompositor(timing, &element, player, effect, playerPlaybackRate));
     ASSERT(canStartAnimationOnCompositor(element));
 
     const KeyframeEffectModelBase& keyframeEffect = toKeyframeEffectModelBase(effect);
 
     RenderLayer* layer = toRenderBoxModelObject(element.renderer())->layer();
     ASSERT(layer);
 
     Vector<OwnPtr<WebCompositorAnimation>> animations;
     CompositorAnimationsImpl::getAnimationOnCompositor(timing, group, startTime, timeOffset, keyframeEffect, animations, playerPlaybackRate);
     ASSERT(!animations.isEmpty());
@@ skipping 344 matching lines @@
             break;
         default:
             ASSERT_NOT_REACHED();
         }
         animations.append(animation.release());
     }
     ASSERT(!animations.isEmpty());
 }
 
 } // namespace blink