Fix a crash which occurs due to a CHECK firing in the HWNDMessageHandler::OnKeyEvent code path on W…

Fix a crash which occurs due to a CHECK firing in the HWNDMessageHandler::OnKeyEvent code path on Windows.

This crash occurs when the LegacyRenderWidgetHostHWND instance sends WM_CHAR/WM_SYSCHAR messages via the
WindowEventTarget::HandleKeyboardMessage function.

The HWNDMessageHandler class handles these messages via the OnImeMessages handler in the normal case.

The CHECK fires in the KeyEvent ctor where we validate that the KeyEvent instance has a valid event type.
In this case the WM_CHAR/WM_SYSCHAR messages are processed via the OnKeyEvent handler which leads to the problem.

Fix is to add a check for WM_CHAR/WM_SYSCHAR messages in the HWNDMessageHandler::HandleKeyboardMessage function
and call the OnImeMessages handler there. The alternative would be to add a new method to the WindowEventTarget
interface and change the LegacyRenderWidgetHostHWND class to handle these messages separately and call the new
method. I think that change would be a touch big for this case.

I also added WM_SYSDEADCHAR to the list of messages processed by the EventTypeFromNative function. We set the
type as ET_KEY_RELEASED on the same lines as WM_DEADCHAR.

BUG=451797
TEST=Covered by views_unittest WidgetTest.CharMessagesAsKeyboardMessagesDoesNotCrash

Committed: https://crrev.com/005229b167c1a9e415fc814520bf1d650adebb22
Cr-Commit-Position: refs/heads/master@{#313591}

[ananta, 2015-01-28 02:14:07]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-01-28 20:08:23]

https://codereview.chromium.org/881163002/diff/1/ui/views/win/hwnd_message_ha...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/881163002/diff/1/ui/views/win/hwnd_message_ha...
ui/views/win/hwnd_message_handler.cc:1013: if ((message == WM_CHAR) || (message
== WM_SYSCHAR))
Isn't it possible for HandleKeyboardMessage to be invoked outside of legacy
hwnd? Should you only special case the path when events are forwarded from
legacy hwnd?

[ananta, 2015-01-28 20:27:42]

https://codereview.chromium.org/881163002/diff/1/ui/views/win/hwnd_message_ha...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/881163002/diff/1/ui/views/win/hwnd_message_ha...
ui/views/win/hwnd_message_handler.cc:1013: if ((message == WM_CHAR) || (message
== WM_SYSCHAR))
On 2015/01/28 20:08:23, sky wrote:
> Isn't it possible for HandleKeyboardMessage to be invoked outside of legacy
> hwnd? Should you only special case the path when events are forwarded from
> legacy hwnd?

I don't think we need to special case here.

All keyboard messages including the WM_CHAR/WM_SYSCHAR messages fall between
WM_KEYFIRST and WM_KEYLAST. Currently the only way to send keyboard and
character messages via WindowEventTarget is HandleKeyboardMessage. We should be
ok here.

[sky, 2015-01-28 21:29:00]

Ok, LGTM

[ananta, 2015-01-28 21:32:51]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2015-01-28 21:34:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/881163002/1

[commit-bot: I haz the power, 2015-01-28 21:38:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-28 21:40:49]

Patchset 1 (id:??) landed as
https://crrev.com/005229b167c1a9e415fc814520bf1d650adebb22
Cr-Commit-Position: refs/heads/master@{#313591}