Chromium Code Reviews
DescriptionRevert of text-combine should scale rather than fall back to none when wide (patchset #5 id:180001 of https://codereview.chromium.org/799123003/)
Reason for revert:
Makes fast/text/text-combine-selection-crash.html crash on mac:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ftext%2Ftext-combine-selection-crash.html&testType=layout-tests
Original issue's description:
> text-combine should scale rather than fall back to none when wide
>
> This patch follows the CSS spec change in 2014 CR:
> Old: Combine if vertical flow and its width <= ~1em
> Current: Combine if vertical flow. Scale if width > ~1em
>
> CR: http://www.w3.org/TR/css-writing-modes-3/#text-combine
> ED: http://dev.w3.org/csswg/css-writing-modes/#text-combine
>
> In addition to the changes to RenderCombineText, this spec change has a
> small but pleasant side effect to our implementation. The
> RenderCombinedText delays the width calculation until it's needed. But the
> spec also says that it has to be treated as an U+FFFC OBJECT REPLACEMENT
> CHARACTER to line breakers when combined.
>
> From these two facts, line breakers must be aware of RenderCombinedText and
> update it (combineText()) when needed. Also, the fact that combineText()
> could change the length of text brought additional complexity. We have a
> few calls to combineText() in line breakers, and still has some flakiness
> such as bug 312606. The new spec eliminates this complexity, so our line
> breakers are a bit cleaner, faster, and less flaky.
>
> fast/text/font-variant-width.html had to be rewritten because it relied on
> the behavior of text-combine to fallback when wide.
>
> BUG=433176, 312606
> TEST=fast/writing-mode/text-combine-compress.html
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189235
TBR=kouhei@chromium.org,leviw@chromium.org,kojii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=433176, 312606
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (1 generated)
|