Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 881093003: Normalize import paths for Sky modules (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel, eseidel1, ojan
CC:
ojan, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Normalize import paths for Sky modules This CL simplifies the sky_server to only map the build directory into /gen, which will make the deploy script simpler. This CL updates all the imports to use the /gen prefix when referring to generated files. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ade24563ed61b05665d7bdbcf5d05bef98c541fe

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -75 lines) Patch
M mojo/public/sky/convert_amd_modules_to_sky.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.sky.tmpl View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/framework/embedder.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/inspector/inspector.sky View 1 chunk +9 lines, -9 lines 0 comments Download
M sky/framework/inspector/page-agent.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/shell.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/sky-box.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/sky-button.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/sky-checkbox.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/sky-input.sky View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/framework/sky-radio.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/sky-scrollable.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/xmlhttprequest.sky View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/tests/framework/templates.sky View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/tests/framework/xmlhttprequest/empty-responseType.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/framework/xmlhttprequest/responseType.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/framework/xmlhttprequest/unicode-post.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/framework/xmlhttprequest/xhr.sky View 1 chunk +2 lines, -2 lines 1 comment Download
M sky/tests/framework/xmlhttprequest/xhr-does-not-exist.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/framework/xmlhttprequest/xhr-relative.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/inspector/page-agent-get-resource-tree.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/resources/event-sender.sky View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/tests/services/buffer.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/codec.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/core.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/event-sender.sky View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/tests/services/network.sky View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/tools/skygo/sky_server.go View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/tools/skygo/sky_server.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
abarth-chromium
5 years, 11 months ago (2015-01-28 00:56:06 UTC) #1
abarth-chromium
Committed patchset #1 (id:1) manually as ade24563ed61b05665d7bdbcf5d05bef98c541fe (presubmit successful).
5 years, 11 months ago (2015-01-28 01:04:45 UTC) #2
ojan
lgtm
5 years, 11 months ago (2015-01-28 01:16:55 UTC) #4
eseidel1
https://codereview.chromium.org/881093003/diff/1/sky/tests/framework/xmlhttprequest/xhr.sky File sky/tests/framework/xmlhttprequest/xhr.sky (right): https://codereview.chromium.org/881093003/diff/1/sky/tests/framework/xmlhttprequest/xhr.sky#newcode2 sky/tests/framework/xmlhttprequest/xhr.sky:2: <import src="../../resources/chai.sky" /> Why move to relative paths?
5 years, 11 months ago (2015-01-28 06:08:33 UTC) #6
abarth-chromium
5 years, 10 months ago (2015-01-28 17:10:23 UTC) #7
Message was sent while issue was closed. 
On 2015/01/28 at 06:08:33, eseidel wrote:
>
https://codereview.chromium.org/881093003/diff/1/sky/tests/framework/xmlhttpr...
> File sky/tests/framework/xmlhttprequest/xhr.sky (right):
> 
>
https://codereview.chromium.org/881093003/diff/1/sky/tests/framework/xmlhttpr...
> sky/tests/framework/xmlhttprequest/xhr.sky:2: <import
src="../../resources/chai.sky" />
> Why move to relative paths?

I switched all the "within component" references to relative paths.  For
example, that means someone could take the |framework| directory and move it
wherever they wanted on their server.  I did the same for the |tests| directory,
but maybe that was overly general.

Powered by Google App Engine
This is Rietveld 408576698