Issue 881023003: Revert of patch from issue 885453002 at patchset 20001 (http://crrev.com/885453002#ps20001)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 881023003: Revert of patch from issue 885453002 at patchset 20001 (http://crrev.com/885453002#ps20001) (Closed)

Created:
5 years, 10 months ago by mtklein

Modified:
5 years, 10 months ago

Reviewers:
mtklein_C

CC:
herb, reed1, hal.canary, reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of patch from issue 885453002 at patchset 20001 (http://crrev.com/885453002#ps20001) (patchset #1 id:1 of https://codereview.chromium.org/881953002/) Reason for revert: ==32435==ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs operator delete) on 0x621000d8cd00 Lots of info here: http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN/builds/1198/steps/dm/logs/stdio Original issue's description: > patch from issue 885453002 at patchset 20001 (http://crrev.com/885453002#ps20001) > > Make the char cache dynamic in SkGlyphCache > because it is rarely used. > > Landing on behalf of Herb. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/95faa61d63a6f62916f6f7be58c4624da8357e3b TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/25b76119e949fb064c840003a2e92633c25e8cdf

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -21 lines)			Patch
	M	src/core/SkGlyphCache.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	src/core/SkGlyphCache.cpp	View		7 chunks	+9 lines, -17 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of patch from issue 885453002 at patchset 20001 (http://crrev.com/885453002#ps20001)

5 years, 10 months ago (2015-01-27 23:38:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881023003/1

5 years, 10 months ago (2015-01-27 23:39:15 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-01-27 23:39:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/25b76119e949fb064c840003a2e92633c25e8cdf