Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 881023002: media: Rename PERMISSION_PROTECTED_MEDIA to PERMISSION_PROTECTED_MEDIA_IDENTIFIER. (Closed)

Created:
5 years, 11 months ago by xhwang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, eme-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, markusheintz_, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Rename PERMISSION_PROTECTED_MEDIA to PERMISSION_PROTECTED_MEDIA_IDENTIFIER. This makes the naming consistent with other use cases, e.g. CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER, ProtectedMediaIdentifierPermissionContext etc. BUG=446263 TEST=Renaming only. Committed: https://crrev.com/8624637f95b03edcc9237150be85c50be3678358 Cr-Commit-Position: refs/heads/master@{#313582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M android_webview/browser/aw_content_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/permission_context_uma_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/permission_type.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
xhwang
As discussed in my previous CL.... PTAL
5 years, 11 months ago (2015-01-27 19:18:08 UTC) #3
sandersd (OOO until July 31)
lgtm
5 years, 11 months ago (2015-01-27 20:51:36 UTC) #4
xhwang
jam@: This is a renaming only CL. Please OWNERS review content/public/browser/permission_type.h and other content/* files. ...
5 years, 11 months ago (2015-01-27 20:55:15 UTC) #6
jam
lgtm
5 years, 10 months ago (2015-01-28 16:13:51 UTC) #7
xhwang
isherman@chromium.org: Please review changes in tools/metrics/histograms/histograms.xml; it's a renaming only change.
5 years, 10 months ago (2015-01-28 17:06:35 UTC) #9
Ilya Sherman
histograms.xml lgtm
5 years, 10 months ago (2015-01-28 19:24:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881023002/1
5 years, 10 months ago (2015-01-28 20:07:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 21:10:30 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 21:11:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8624637f95b03edcc9237150be85c50be3678358
Cr-Commit-Position: refs/heads/master@{#313582}

Powered by Google App Engine
This is Rietveld 408576698