Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Issue 881013002: Roll pdfium to eef005055d6aafc2cc6066af37ce47d8b15ec7cd (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll pdfium to eef005055d6aafc2cc6066af37ce47d8b15ec7cd There is a small API change in a recently-added pdfium API exposed by this roll, so pdfium_engine.cc is simultaneously updated to match. This pulls in: eef0050 Kill scattered extern _PDF_CharType declarations. a039323 Fix infinite recursion in CPDF_Parser::ParseIndirectObjectAt(). fa370ac Fix test naming in previous commit. e0bbe4a Fix null crash in CheckTrailer. af9be4f Add pdfium_embeddertests to BUILD.gn 36faa4a Fix build of pdfium_embeddertest under V8_USE_EXTERNAL_STARTUP_DATA. 219e462 Use IPDF_DataAvail interface to hide CPDF_DataAvail. 83f96a0 Add API tests: NamedDestsByName, DestGetPageIndex. 9dcd7b8 Add tests for GetNamedDests() API. dc43b32 Use signed long for FPDF_GetNamedDest buffer length. 0185408 Simplify UTF16LE_Encode and add unittest. Committed: https://crrev.com/9e41970b70e45478bb08c2378787e4c13ab5ea27 Cr-Commit-Position: refs/heads/master@{#313344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Lei, please review.
5 years, 11 months ago (2015-01-27 18:42:47 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-27 19:22:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881013002/1
5 years, 11 months ago (2015-01-27 20:18:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 20:22:44 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:24:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e41970b70e45478bb08c2378787e4c13ab5ea27
Cr-Commit-Position: refs/heads/master@{#313344}

Powered by Google App Engine
This is Rietveld 408576698