Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 881003003: Fix shadowing warning in json_parser on VS2015 (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-safe_sprintf
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix shadowing warning in json_parser on VS2015 d:\src\cr3\src\base\json\json_parser.cc(431): error C2220: warning treated as error - no 'object' file generated d:\src\cr3\src\base\json\json_parser.cc(431): warning C4456: declaration of 'next_char' hides previous local declaration d:\src\cr3\src\base\json\json_parser.cc(427): note: see declaration of 'next_char' I don't think there's any need for a new variable inside the loop. R=thestig@chromium.org BUG=440500 Committed: https://crrev.com/e5937efe673d362d4c933b2194fa808e32167de1 Cr-Commit-Position: refs/heads/master@{#313374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/json/json_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
scottmg
5 years, 11 months ago (2015-01-27 19:24:24 UTC) #1
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-27 19:30:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881003003/1
5 years, 11 months ago (2015-01-27 19:32:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/18790)
5 years, 11 months ago (2015-01-27 20:47:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881003003/1
5 years, 11 months ago (2015-01-27 20:51:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/18790)
5 years, 11 months ago (2015-01-27 20:52:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881003003/1
5 years, 11 months ago (2015-01-27 22:10:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 22:12:51 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 22:14:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5937efe673d362d4c933b2194fa808e32167de1
Cr-Commit-Position: refs/heads/master@{#313374}

Powered by Google App Engine
This is Rietveld 408576698