Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 880983009: Fix isInternalProperty when there are no internal properties (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix isInternalProperty when there are no internal properties Before my patch isInternalProperty would look like: .... switch (id) { return true; default: return false; } ... since we have no internal properties at the moment. With this patch it is simply: { return false; } BUG=396992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M Source/build/scripts/make_css_property_names.py View 2 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rwlbuis
PTAL
5 years, 10 months ago (2015-01-30 23:41:48 UTC) #2
Timothy Loh
Do we still need this concept at all? I think I talked with Julien about ...
5 years, 10 months ago (2015-02-01 22:50:18 UTC) #4
rwlbuis
5 years, 10 months ago (2015-02-02 01:57:35 UTC) #5
On 2015/02/01 22:50:18, Timothy Loh wrote:
> Do we still need this concept at all? I think I talked with Julien about it a
> while ago but I don't remember if we decided on anything.

That would be fine by me. I prepared https://codereview.chromium.org/879443006/
in case we want to do that.

Powered by Google App Engine
This is Rietveld 408576698