More cleanup around GrContext, textures, and SkGr.cpp

More cleanup around GrContext, textures, and SkGr.cpp

Committed: https://skia.googlesource.com/skia/+/d2a6f4e419393d3c8d8fe332f11c4c6f88382e1d

[bsalomon, 2015-02-01 03:37:50]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-02-01 03:37:51]

Smaller cleanups

https://codereview.chromium.org/880983008/diff/1/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (left):

https://codereview.chromium.org/880983008/diff/1/src/gpu/SkGr.cpp#oldcode461
src/gpu/SkGr.cpp:461: else {
This else meant that when etc1 was compiled in and supported, we usually
wouldn't use the yuv path!

[robertphillips, 2015-02-02 13:26:27]

lgtm

[robertphillips, 2015-02-02 13:26:30]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-02-02 13:27:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880983008/1

[commit-bot: I haz the power, 2015-02-02 13:27:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-02 13:27:03]

Failed to apply patch for include/gpu/GrContext.h:
While running git apply --index -3 -p1;
  error: patch failed: include/gpu/GrContext.h:274
  Falling back to three-way merge...
  Applied patch to 'include/gpu/GrContext.h' with conflicts.
  U include/gpu/GrContext.h

Patch:       include/gpu/GrContext.h
Index: include/gpu/GrContext.h
diff --git a/include/gpu/GrContext.h b/include/gpu/GrContext.h
index
88a31484ed7c1c7d1d9078f4d9f5db437f7145c3..926b95f2506756cb1ae4ecaa37aed57dda1db1af
100644
--- a/include/gpu/GrContext.h
+++ b/include/gpu/GrContext.h
@@ -274,9 +274,14 @@ public:
                                  bool internalFlag = false);
 
     /**
-     * Returns true if index8 textures are supported.
+     * Can the provided configuration act as a texture?
      */
-    bool supportsIndex8PixelConfig() const;
+    bool isConfigTexturable(GrPixelConfig) const;
+
+    /**
+     * Can non-power-of-two textures be used with tile modes other than clamp?
+     */
+    bool npotTextureTileSupport() const;
 
     /**
      *  Return the max width or height of a texture supported by the current
GPU.

[bsalomon, 2015-02-03 23:00:19]

Depends on https://codereview.chromium.org/890223003

[bsalomon, 2015-02-04 18:48:42]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-02-04 18:49:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880983008/40001

[commit-bot: I haz the power, 2015-02-04 18:55:59]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d2a6f4e419393d3c8d8fe332f11c4c6f88382e1d