Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 880973002: Instrumenting CopyData to analyze its slowing down (Closed)

Created:
5 years, 11 months ago by vadimt
Modified:
5 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumenting CopyData to analyze its slowing down The previous CL moved the copy part from IO thread. Now, in the worker thread, copying data 15ms on average, instead of the old 5ms in IO thread, which I want to investigate. I want to separate possible slowness from the task wrapper (what if params are copied in an inefficient way?) from the slowness from the memcpy. BUG=422489 Committed: https://crrev.com/a0046208af1f285b95809ed9e79a48f8d95a1522 Cr-Commit-Position: refs/heads/master@{#313306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M net/url_request/url_request_simple_job.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vadimt
mmenke@, please review
5 years, 11 months ago (2015-01-27 16:20:50 UTC) #2
mmenke
On 2015/01/27 16:20:50, vadimt wrote: > mmenke@, please review LGTM
5 years, 11 months ago (2015-01-27 16:22:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880973002/1
5 years, 11 months ago (2015-01-27 16:23:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 18:11:23 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 18:12:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0046208af1f285b95809ed9e79a48f8d95a1522
Cr-Commit-Position: refs/heads/master@{#313306}

Powered by Google App Engine
This is Rietveld 408576698