components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc - Issue 880963006: Create a new DataReductionProxyConfig class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

Issue 880963006: Create a new DataReductionProxyConfig class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

index d577fcee44711dde66ddc373a228a812240435f1..26de12c3044d10d489dec033508ae65eea8865db 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

@@ -181,12 +181,12 @@ class DataReductionProxyInterceptorWithServerTest : public testing::Test {

ASSERT_TRUE(direct_.InitializeAndWaitUntilReady());

// Owned by settings_.

- TestDataReductionProxyParams* params =

- new TestDataReductionProxyParams(

- DataReductionProxyParams::kAllowed,

- TestDataReductionProxyParams::HAS_EVERYTHING &

+ scoped_ptr<TestDataReductionProxyParams> params;

+ params.reset(new TestDataReductionProxyParams(

+ DataReductionProxyParams::kAllowed,

+ TestDataReductionProxyParams::HAS_EVERYTHING &

~TestDataReductionProxyParams::HAS_DEV_ORIGIN &

- ~TestDataReductionProxyParams::HAS_DEV_FALLBACK_ORIGIN);

+ ~TestDataReductionProxyParams::HAS_DEV_FALLBACK_ORIGIN));

params->set_origin(proxy_.GetURL("/"));

std::string proxy_name =

net::HostPortPair::FromURL(GURL(params->origin())).ToString();

@@ -196,7 +196,7 @@ class DataReductionProxyInterceptorWithServerTest : public testing::Test {

context_.set_proxy_service(proxy_service_.get());

- settings_.reset(new DataReductionProxySettings(params));

+ settings_.reset(new DataReductionProxySettings(params.Pass()));

io_data_.reset(

new DataReductionProxyIOData(

data_reduction_proxy::Client::UNKNOWN,