Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880853002: Refix of adb gdb su usage (Closed)

Created:
5 years, 11 months ago by ripp
Modified:
5 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refix of adb gdb su usage Quotes to command now adding only if "su -c" parameter is present. R=jbudorick@chromium.org BUG=452237 Committed: https://crrev.com/e86f141f9838096a7ace7f2353f4c28eeb72a67b Cr-Commit-Position: refs/heads/master@{#313675}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed redundant line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M build/android/adb_gdb View 1 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
ripp
5 years, 11 months ago (2015-01-27 08:06:29 UTC) #1
jbudorick
https://codereview.chromium.org/880853002/diff/1/build/android/adb_gdb File build/android/adb_gdb (right): https://codereview.chromium.org/880853002/diff/1/build/android/adb_gdb#newcode875 build/android/adb_gdb:875: MAPPINGS=$(adb_shell $COMMAND_PREFIX cat /proc/$PID/maps $COMMAND_SUFFIX) Shouldn't this replace the ...
5 years, 11 months ago (2015-01-27 14:24:43 UTC) #2
ripp
https://codereview.chromium.org/880853002/diff/1/build/android/adb_gdb File build/android/adb_gdb (right): https://codereview.chromium.org/880853002/diff/1/build/android/adb_gdb#newcode875 build/android/adb_gdb:875: MAPPINGS=$(adb_shell $COMMAND_PREFIX cat /proc/$PID/maps $COMMAND_SUFFIX) On 2015/01/27 14:24:43, jbudorick ...
5 years, 10 months ago (2015-01-28 07:01:32 UTC) #3
jbudorick
lgtm
5 years, 10 months ago (2015-01-28 14:24:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880853002/20001
5 years, 10 months ago (2015-01-29 06:51:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 07:25:26 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 07:26:18 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e86f141f9838096a7ace7f2353f4c28eeb72a67b
Cr-Commit-Position: refs/heads/master@{#313675}

Powered by Google App Engine
This is Rietveld 408576698