Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 880803004: Revert of Revert of Swarm cc_unittests. (Closed)

Created:
5 years, 11 months ago by jam
Modified:
5 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Swarm cc_unittests. (patchset #1 id:1 of https://codereview.chromium.org/861173002/) Reason for revert: just saw this revert. can't find sergeyv online, and don't see information on what broke. so reverting the revert and watching the tree. Original issue's description: > Revert of Swarm cc_unittests. (patchset #6 id:100001 of https://codereview.chromium.org/854743002/) > > Reason for revert: > Failures on chrome.mac > > Original issue's description: > > Swarm cc_unittests. > > > > BUG=448877 > > > > Committed: https://crrev.com/9086ff0072268267bacf28e6098a7b5bd8478982 > > Cr-Commit-Position: refs/heads/master@{#312252} > > TBR=maruel@chromium.org,alexst@chromium.org,jam@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=448877 > > Committed: https://crrev.com/c497f3788bc5007ee3bbe2f6aa1cc101b6d66d8b > Cr-Commit-Position: refs/heads/master@{#312322} TBR=maruel@chromium.org,alexst@chromium.org,sergeyv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448877 Committed: https://crrev.com/75a28f07d5c54d2c0ea5ad59718038599b4b7287 Cr-Commit-Position: refs/heads/master@{#313294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -15 lines) Patch
M cc/cc_tests.gyp View 1 chunk +18 lines, -1 line 0 comments Download
A cc/cc_unittests.isolate View 1 chunk +83 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +18 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +24 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +30 lines, -5 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +6 lines, -1 line 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Revert of Swarm cc_unittests.
5 years, 11 months ago (2015-01-27 17:21:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880803004/1
5 years, 11 months ago (2015-01-27 17:21:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 17:23:02 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 17:25:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75a28f07d5c54d2c0ea5ad59718038599b4b7287
Cr-Commit-Position: refs/heads/master@{#313294}

Powered by Google App Engine
This is Rietveld 408576698