Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880783003: Do not add indirection to XML_Parser. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Do not add indirection to XML_Parser. The expat type XML_Parser is already a pointer, so pass it by value instead of by indirection. Committed: https://skia.googlesource.com/skia/+/3af41fab932f5ab1c6ef57cbf3aad0c0ed550f6e

Patch Set 1 #

Patch Set 2 : Build locally after rebasing all the changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/ports/SkFontConfigParser_android.cpp View 1 9 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bungeman-skia
5 years, 10 months ago (2015-01-30 22:24:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880783003/1
5 years, 10 months ago (2015-01-30 22:24:17 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-30 22:24:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1784)
5 years, 10 months ago (2015-01-30 22:25:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880783003/20001
5 years, 10 months ago (2015-01-30 22:29:16 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-30 22:29:17 UTC) #10
mtklein
lgtm
5 years, 10 months ago (2015-01-30 22:50:54 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 22:53:02 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3af41fab932f5ab1c6ef57cbf3aad0c0ed550f6e

Powered by Google App Engine
This is Rietveld 408576698