Issue 880783002: Revert of Split src/opts source lists out of opts.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 880783002: Revert of Split src/opts source lists out of opts.gyp. (Closed)

Created:
5 years, 11 months ago by mtklein

Modified:
5 years, 11 months ago

Reviewers:
mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Split src/opts source lists out of opts.gyp. (patchset #1 id:1 of https://codereview.chromium.org/870353003/) Reason for revert: Android Makefiles broken Original issue's description: > Split src/opts source lists out of opts.gyp. > > This should make it easier to keep our opts.gyp in sync with Chrome's GYP and GN. > > BUG=skia: > > Landing this without review as a mega-tryjob. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/c98fe3aa4f8c97c462c0eb6d9106fc37e48d7f82 TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0933725e492cfdb7cdb1b5cbbc6f89ca50b27ea0

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+205 lines, -137 lines)			Patch
M	gyp/opts.gyp	View	6 chunks	+204 lines, -53 lines	0 comments	Download
D	gyp/opts.gypi	View	1 chunk	+0 lines, -83 lines	0 comments	Download
M	gyp/skia_lib.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Split src/opts source lists out of opts.gyp.

5 years, 11 months ago (2015-01-27 02:14:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880783002/1

5 years, 11 months ago (2015-01-27 02:15:23 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-27 02:15:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0933725e492cfdb7cdb1b5cbbc6f89ca50b27ea0