Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 880773009: VP8Decoder: Drop references to reference frames earlier. (Closed)

Created:
5 years, 10 months ago by Pawel Osciak
Modified:
5 years, 10 months ago
Reviewers:
wuchengli
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VP8Decoder: Drop references to reference frames earlier. Drop references to reference frames before requesting new surfaces to ensure we don't hold onto them while the Accelerator is changing resolution, risking reusing a stale buffer. BUG=chrome-os-partner:35539 TEST=Hangouts, vdatest Committed: https://crrev.com/0f47fc976b37b54583a061b0628f994bf727ba30 Cr-Commit-Position: refs/heads/master@{#313679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/vp8_decoder.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Pawel Osciak
5 years, 10 months ago (2015-01-29 05:47:43 UTC) #2
wuchengli
lgtm
5 years, 10 months ago (2015-01-29 08:03:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880773009/1
5 years, 10 months ago (2015-01-29 08:05:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 08:39:50 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 08:40:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f47fc976b37b54583a061b0628f994bf727ba30
Cr-Commit-Position: refs/heads/master@{#313679}

Powered by Google App Engine
This is Rietveld 408576698