Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 880773002: OOP PDF: Set the pdf extension URL permissions to <all_urls>. (Closed)

Created:
5 years, 10 months ago by Sam McNally
Modified:
5 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OOP PDF: Set the pdf extension URL permissions to <all_urls>. Currently, the PDF extension isn't permitted access to paths to network mounts (e.g. file://network_share/path.pdf). A permission of <all_urls> allows access to such URLs. BUG=452319 Committed: https://crrev.com/c064ddad5554afe987ef088d4bf1165cc7eda74e Cr-Commit-Position: refs/heads/master@{#313215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/resources/pdf/manifest-common.json.unflattened View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
5 years, 10 months ago (2015-01-27 01:34:53 UTC) #2
raymes
lgtm, thanks!
5 years, 10 months ago (2015-01-27 01:37:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880773002/1
5 years, 10 months ago (2015-01-27 01:40:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-27 03:09:41 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 03:12:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c064ddad5554afe987ef088d4bf1165cc7eda74e
Cr-Commit-Position: refs/heads/master@{#313215}

Powered by Google App Engine
This is Rietveld 408576698