Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: util/net/http_transport_test.cc

Issue 880763002: Reorganize Multiprocess and implement for Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: fixes 2 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/test/mac/mach_multiprocess.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/net/http_transport_test.cc
diff --git a/util/net/http_transport_test.cc b/util/net/http_transport_test.cc
index 0a91fa56e61b9c0fc22226983658fc36a8e0ab72..8fb8a57df7a1f12ab7350f7778b67df0381b1a7b 100644
--- a/util/net/http_transport_test.cc
+++ b/util/net/http_transport_test.cc
@@ -69,18 +69,18 @@ class HTTPTransportTestFixture : public MultiprocessExec {
private:
void MultiprocessParent() override {
- // Use Logging*FD() instead of Checked*FD() so that the test can fail
+ // Use Logging*File() instead of Checked*File() so that the test can fail
// gracefully with a gtest assertion if the child does not execute properly.
// The child will write the HTTP server port number as a packed unsigned
// short to stdout.
uint16_t port;
- ASSERT_TRUE(LoggingReadFile(ReadPipeFD(), &port, sizeof(port)));
+ ASSERT_TRUE(LoggingReadFile(ReadPipeHandle(), &port, sizeof(port)));
// Then the parent will tell the web server what response code to send
// for the HTTP request.
ASSERT_TRUE(LoggingWriteFile(
- WritePipeFD(), &response_code_, sizeof(response_code_)));
+ WritePipeHandle(), &response_code_, sizeof(response_code_)));
// Now execute the HTTP request.
scoped_ptr<HTTPTransport> transport(HTTPTransport::Create());
@@ -97,7 +97,7 @@ class HTTPTransportTestFixture : public MultiprocessExec {
std::string request;
char buf[32];
ssize_t bytes_read;
- while ((bytes_read = ReadFile(ReadPipeFD(), buf, sizeof(buf))) != 0) {
+ while ((bytes_read = ReadFile(ReadPipeHandle(), buf, sizeof(buf))) != 0) {
ASSERT_GE(bytes_read, 0);
request.append(buf, bytes_read);
}
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/test/mac/mach_multiprocess.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698