Reorganize Multiprocess and implement for Windows

util/test/multiprocess_posix.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/test/multiprocess.h"
 
 #include <signal.h>
 #include <stdlib.h>
 #include <sys/wait.h>

[Mark Mentovai, 2015/01/28 22:32:54]

This needs <unistd.h> now that you’ve removed it from the header.

[scottmg, 2015/01/28 22:48:25]

Done.

 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/files/scoped_file.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/strings/stringprintf.h"
 #include "gtest/gtest.h"
@@ skipping 116 matching lines @@
 
   info_->pipe_p2c_read.reset(pipe_fds_p2c[0]);
   info_->pipe_p2c_write.reset(pipe_fds_p2c[1]);
 }
 
 pid_t Multiprocess::ChildPID() const {
   EXPECT_NE(0, info_->child_pid);
   return info_->child_pid;
 }
 
-int Multiprocess::ReadPipeFD() const {
+FileHandle Multiprocess::ReadPipeHandle() const {
   int fd = info_->child_pid ? info_->pipe_c2p_read.get()
                             : info_->pipe_p2c_read.get();
   CHECK_NE(fd, -1);
   return fd;
 }
 
-int Multiprocess::WritePipeFD() const {
+FileHandle Multiprocess::WritePipeHandle() const {
   int fd = info_->child_pid ? info_->pipe_p2c_write.get()
                             : info_->pipe_c2p_write.get();
   CHECK_NE(fd, -1);
   return fd;
 }
 
 void Multiprocess::CloseReadPipe() {
   if (info_->child_pid) {
     info_->pipe_c2p_read.reset();
   } else {
@@ skipping 35 matching lines @@
   if (testing::Test::HasFailure()) {
     // Trigger the ScopedForbidReturn destructor.
     return;
   }
 
   exit(0);
 }
 
 }  // namespace test
 }  // namespace crashpad