services/view_manager/display_manager.cc - Issue 880743002: Plumb ViewportMetrics change notifications around the world and back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/view_manager/display_manager.cc

Issue 880743002: Plumb ViewportMetrics change notifications around the world and back. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Now without skydb changes Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/view_manager/display_manager.cc

diff --git a/services/view_manager/display_manager.cc b/services/view_manager/display_manager.cc

index 2c312c752e9c5fac587b36d9b30d3561cf609a87..f9e1e075965421ff3285ebeb38e66c882cc14abc 100644

--- a/services/view_manager/display_manager.cc

+++ b/services/view_manager/display_manager.cc

@@ -176,7 +176,9 @@ void DefaultDisplayManager::OnMetricsChanged(mojo::ViewportMetricsPtr metrics) {

metrics_.size = metrics->size.Pass();

metrics_.device_pixel_ratio = metrics->device_pixel_ratio;

gfx::Rect bounds(metrics_.size.To<gfx::Size>());

+ // TODO(sky): Is SetBounds still necessary now with SetViewportMetrics?

sky 2015/01/27 23:40:23 Yes, the two are different.

connection_manager_->root()->SetBounds(bounds);

+ connection_manager_->root()->SetViewportMetrics(metrics_);

if (!surface_allocated_)

return;

surface_->DestroySurface(kLocalSurfaceID);