Plumb ViewportMetrics change notifications around the world and back.

mojo/services/view_manager/public/cpp/lib/view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "view_manager/public/cpp/view.h"
 
 #include <set>
 #include <string>
 
 #include "mojo/public/cpp/application/service_provider_impl.h"
@@ skipping 364 matching lines @@
 void View::Embed(const String& url,
                  InterfaceRequest<ServiceProvider> services,
                  ServiceProviderPtr exposed_services) {
   static_cast<ViewManagerClientImpl*>(manager_)
       ->Embed(url, id_, services.Pass(), exposed_services.Pass());
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // View, protected:
 
+namespace {
+
+ViewportMetricsPtr CreateEmptyViewportMetrics() {

[eseidel, 2015/01/27 22:46:58]

This is unfortunate, but makes it so the caller never gets back a null handle,
only a somewhat nonsensical one.

+  ViewportMetricsPtr metrics = ViewportMetrics::New();
+  metrics->size = Size::New();
+  return metrics;
+}
+}
+
 View::View()
     : manager_(NULL),
       id_(static_cast<Id>(-1)),
       parent_(NULL),
+      viewport_metrics_(CreateEmptyViewportMetrics()),
       visible_(true),
       drawn_(false) {
 }
 
 View::~View() {
   FOR_EACH_OBSERVER(ViewObserver, observers_, OnViewDestroying(this));
   if (parent_)
     parent_->LocalRemoveChild(this);
 
   // We may still have children. This can happen if the embedder destroys the
@@ skipping 19 matching lines @@
   FOR_EACH_OBSERVER(ViewObserver, observers_, OnViewDestroyed(this));
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // View, private:
 
 View::View(ViewManager* manager, Id id)
     : manager_(manager),
       id_(id),
       parent_(nullptr),
+      viewport_metrics_(CreateEmptyViewportMetrics()),
       visible_(false),
       drawn_(false) {
 }
 
 int64 View::SetLocalPropertyInternal(const void* key,
                                      const char* name,
                                      PropertyDeallocator deallocator,
                                      int64 value,
                                      int64 default_value) {
   int64 old = GetLocalPropertyInternal(key, default_value);
@@ skipping 44 matching lines @@
 void View::LocalSetBounds(const Rect& old_bounds,
                           const Rect& new_bounds) {
   DCHECK(old_bounds.x == bounds_.x);
   DCHECK(old_bounds.y == bounds_.y);
   DCHECK(old_bounds.width == bounds_.width);
   DCHECK(old_bounds.height == bounds_.height);
   ScopedSetBoundsNotifier notifier(this, old_bounds, new_bounds);
   bounds_ = new_bounds;
 }
 
+void View::LocalSetViewportMetrics(const ViewportMetrics& old_metrics,
+                                   const ViewportMetrics& new_metrics) {
+  // TODO(eseidel): We could check old_metrics against viewport_metrics_.

[eseidel, 2015/01/27 22:46:58]

I tried, but wasn't able to get them to pass.

+  viewport_metrics_ = new_metrics.Clone();
+  FOR_EACH_OBSERVER(
+      ViewObserver, observers_,
+      OnViewViewportMetricsChanged(this, old_metrics, new_metrics));
+}
+
 void View::LocalSetDrawn(bool value) {
   if (drawn_ == value)
     return;
 
   // As IsDrawn() is derived from |visible_| and |drawn_|, only send drawn
   // notification is the value of IsDrawn() is really changing.
   if (IsDrawn() == value) {
     drawn_ = value;
     return;
   }
@@ skipping 44 matching lines @@
 void View::NotifyViewVisibilityChangedUp(View* target) {
   // Start with the parent as we already notified |this|
   // in NotifyViewVisibilityChangedDown.
   for (View* view = parent(); view; view = view->parent()) {
     bool ret = view->NotifyViewVisibilityChangedAtReceiver(target);
     DCHECK(ret);
   }
 }
 
 }  // namespace mojo