Kill scattered extern _PDF_CharType declarations.

Kill scattered extern _PDF_CharType declarations.

While we're at it, avoid an indirection through a pointer, and
use a name that isn't reserved for the compiler (leading _ CAP).
This is a small portion of the associated bug:

BUG=https://code.google.com/p/pdfium/issues/detail?id=112
R=brucedawson@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/eef005055d6aafc2cc6066af37ce47d8b15ec7cd

[Tom Sepez, 2015-01-27 00:42:02]

tsepez@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Tom Sepez, 2015-01-27 00:42:03]

Bruce, please take a look.

[brucedawson, 2015-01-27 01:13:41]

lgtm

https://codereview.chromium.org/880663003/diff/20001/core/include/fpdfapi/fpd...
File core/include/fpdfapi/fpdf_parser.h (right):

https://codereview.chromium.org/880663003/diff/20001/core/include/fpdfapi/fpd...
core/include/fpdfapi/fpdf_parser.h:55: extern const char PDF_CharType[];
Consider putting the array size here (257). Because this is in a header file the
compiler will check it against the definition. And having the size available to
other translation units may allow static analysis tools to warn about misuses.

Or not. I don't think there are any misuses (such as indexing with char instead
of BYTE types) and I don't know if /analyze would actually find such misuses.

[Tom Sepez, 2015-01-27 02:03:51]

Howzabout now?  I think if I ever have to look at this chart again without the
added legend, I'll going crazy.

[brucedawson, 2015-01-27 02:10:45]

I like it. It's a lot more verbose (the one down side) but it much better
explains how the table works, and it makes it the right size (instead of having
a spurious null-terminator).

[Tom Sepez, 2015-01-27 17:47:36]

(FYI, I cut/pasted the old/new into a small file and coded a loop to ensure they
were equivalent).

[Tom Sepez, 2015-01-27 17:47:49]

Committed patchset #4 (id:60001) manually as
eef005055d6aafc2cc6066af37ce47d8b15ec7cd (presubmit successful).

[brucedawson, 2015-01-27 19:10:39]

lgtm