Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: public/platform/WebContentLayerClient.h

Issue 880653004: Blink side of changes to enable cache clearing without a flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/web/LinkHighlight.h ('K') | « Source/web/WebPopupMenuImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebContentLayerClient.h
diff --git a/public/platform/WebContentLayerClient.h b/public/platform/WebContentLayerClient.h
index 552fe576d02d427ff52d36b4a88fec6b5c680e79..5925f92aca1e560f5665f7fcd131ec1371f1f869 100644
--- a/public/platform/WebContentLayerClient.h
+++ b/public/platform/WebContentLayerClient.h
@@ -42,14 +42,32 @@ public:
// through WebContentLayer::setNeedsDisplay, submitting drawing commands
// through the WebCanvas.
// The canvas is already clipped to the |clip| rect.
- // Optionally, the implementation may set |opaque| to a rect covering pixels that
- // the implementation knows are opaque. This information can be used for various
- // optimizations.
Stephen Chennney 2015/02/03 17:15:23 This comment is referring to something that no lon
// The |disableContext| enum controls most processing in
// GraphicsContext to isolate the painting code in performance tests.
virtual void paintContents(WebCanvas*, const WebRect& clip, GraphicsContextStatus = GraphicsContextEnabled) = 0;
- virtual void paintContents(WebDisplayItemList*, const WebRect& clip, GraphicsContextStatus = GraphicsContextEnabled) = 0;
+ // Temporary to enable Blink+Chromium commit.
+ virtual void paintContents(WebDisplayItemList* list, const WebRect& clip, GraphicsContextStatus status = GraphicsContextEnabled)
+ {
+ paintContents(list, clip, false, status);
+ }
+
+ // Paints the content area for the layer, typically dirty rects submitted
+ // through WebContentLayer::setNeedsDisplay, submitting drawing commands
+ // to populate the WebDisplayItemList.
+ // The |clip| rect defines the region of interest. The resulting WebDisplayItemList should contain
+ // sufficient content to correctly paint the rect, but may also contain other content. The result
+ // will be clipped on playback.
+ // The |clearCaches| flag specifies whether the WebItemDisplayList should regenerate all
+ // content (when |clearCaches| is true) or is free to use cached content. It is only set true
+ // for performance testing.
+ // The |disableContext| enum controls most processing in GraphicsContext to isolate the painting
+ // code in performance tests. Current code always sets it to GraphicsContextEnabled.
+ virtual void paintContents(
+ WebDisplayItemList*,
+ const WebRect& clip,
+ const bool clearCaches = false,
chrishtr 2015/02/03 20:01:21 How about an enum { ShouldRespectPaintCache, Shoul
+ GraphicsContextStatus = GraphicsContextEnabled) = 0;
protected:
virtual ~WebContentLayerClient() { }
« Source/web/LinkHighlight.h ('K') | « Source/web/WebPopupMenuImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698