Issue 880643007: Merge WebWidgetClient into WebViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 880643007: Merge WebWidgetClient into WebViewClient. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Merge WebWidgetClient into WebViewClient. They're always the same thing in sky. I also removed all the methods that don't do anything in sky. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e04721ec0e4e8f5c8dc750b1532174b2656db19d

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -252 lines)			Patch
M	sky/engine/core/dom/Element.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/loader/EmptyClients.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/page/ChromeClient.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	sky/engine/public/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/public/web/WebTouchAction.h	View	1 chunk	+0 lines, -52 lines	0 comments	Download
M	sky/engine/public/web/WebViewClient.h	View	2 chunks	+27 lines, -5 lines	0 comments	Download
D	sky/engine/public/web/WebWidgetClient.h	View	1 chunk	+0 lines, -140 lines	0 comments	Download
M	sky/engine/web/AssertMatchingEnums.cpp	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	sky/engine/web/ChromeClientImpl.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/web/ChromeClientImpl.cpp	View	5 chunks	+0 lines, -34 lines	0 comments	Download
M	sky/viewer/document_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

esprehn

5 years, 11 months ago (2015-01-26 23:55:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e04721ec0e4e8f5c8dc750b1532174b2656db19d (presubmit successful).