Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: mojo/services/network/network_service_impl.cc

Issue 880613005: De-Clientize UDPSocket service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rollin
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/services/network/public/cpp/udp_socket_wrapper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/network/network_service_impl.h" 5 #include "mojo/services/network/network_service_impl.h"
6 6
7 #include "mojo/services/network/cookie_store_impl.h" 7 #include "mojo/services/network/cookie_store_impl.h"
8 #include "mojo/services/network/net_adapters.h" 8 #include "mojo/services/network/net_adapters.h"
9 #include "mojo/services/network/tcp_bound_socket_impl.h" 9 #include "mojo/services/network/tcp_bound_socket_impl.h"
10 #include "mojo/services/network/udp_socket_impl.h" 10 #include "mojo/services/network/udp_socket_impl.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 ScopedDataPipeConsumerHandle send_stream, 59 ScopedDataPipeConsumerHandle send_stream,
60 ScopedDataPipeProducerHandle receive_stream, 60 ScopedDataPipeProducerHandle receive_stream,
61 InterfaceRequest<TCPConnectedSocket> client_socket, 61 InterfaceRequest<TCPConnectedSocket> client_socket,
62 const Callback<void(NetworkErrorPtr, NetAddressPtr)>& callback) { 62 const Callback<void(NetworkErrorPtr, NetAddressPtr)>& callback) {
63 // TODO(brettw) implement this. We need to know what type of socket to use 63 // TODO(brettw) implement this. We need to know what type of socket to use
64 // so we can create the right one (i.e. to pass to TCPSocket::Open) before 64 // so we can create the right one (i.e. to pass to TCPSocket::Open) before
65 // doing the connect. 65 // doing the connect.
66 callback.Run(MakeNetworkError(net::ERR_NOT_IMPLEMENTED), NetAddressPtr()); 66 callback.Run(MakeNetworkError(net::ERR_NOT_IMPLEMENTED), NetAddressPtr());
67 } 67 }
68 68
69 void NetworkServiceImpl::CreateUDPSocket(InterfaceRequest<UDPSocket> socket) { 69 void NetworkServiceImpl::CreateUDPSocket(InterfaceRequest<UDPSocket> request) {
70 BindToRequest(new UDPSocketImpl(), &socket); 70 // The lifetime of this UDPSocketImpl is bound to that of the underlying pipe.
71 new UDPSocketImpl(request.Pass());
71 } 72 }
72 73
73 } // namespace mojo 74 } // namespace mojo
OLDNEW
« no previous file with comments | « no previous file | mojo/services/network/public/cpp/udp_socket_wrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698