Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880603003: Copy Smart Lock user preferences to local state so we can access them on the sign-in screen. (Closed)

Created:
5 years, 11 months ago by Tim Song
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy Smart Lock user preferences to local state so we can access them on the sign-in screen. The only preference right now is proximityRequired, which is now returned through the chrome.easyUnlockPrivate.getUserInfo API. BUG=403419 Committed: https://crrev.com/e84f9035d530e39753dda03ec65076390ba88d72 Cr-Commit-Position: refs/heads/master@{#313409}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : address comments #

Total comments: 2

Patch Set 4 : update idl comment #

Patch Set 5 : update comments #

Total comments: 2

Patch Set 6 : change name to requireCloseProximity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -0 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 1 2 3 4 5 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 2 3 4 5 3 chunks +35 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 2 4 chunks +26 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/easy_unlock_private.idl View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
Tim Song
5 years, 11 months ago (2015-01-27 03:20:10 UTC) #2
Ilya Sherman
LGTM, thanks. https://codereview.chromium.org/880603003/diff/20001/chrome/common/pref_names.h File chrome/common/pref_names.h (right): https://codereview.chromium.org/880603003/diff/20001/chrome/common/pref_names.h#newcode412 chrome/common/pref_names.h:412: extern const char kEasyUnlockLocalStateUserPrefs[]; nit: Alphabetize, please.
5 years, 11 months ago (2015-01-27 03:31:05 UTC) #3
xiyuan
lgtm https://codereview.chromium.org/880603003/diff/20001/chrome/browser/signin/easy_unlock_service_regular.cc File chrome/browser/signin/easy_unlock_service_regular.cc (right): https://codereview.chromium.org/880603003/diff/20001/chrome/browser/signin/easy_unlock_service_regular.cc#newcode337 chrome/browser/signin/easy_unlock_service_regular.cc:337: update->RemoveWithoutPathExpansion(user_email, NULL); nit: no need to remove since ...
5 years, 11 months ago (2015-01-27 04:14:05 UTC) #4
Tim Song
https://codereview.chromium.org/880603003/diff/20001/chrome/browser/signin/easy_unlock_service_regular.cc File chrome/browser/signin/easy_unlock_service_regular.cc (right): https://codereview.chromium.org/880603003/diff/20001/chrome/browser/signin/easy_unlock_service_regular.cc#newcode337 chrome/browser/signin/easy_unlock_service_regular.cc:337: update->RemoveWithoutPathExpansion(user_email, NULL); On 2015/01/27 04:14:05, xiyuan wrote: > nit: ...
5 years, 10 months ago (2015-01-27 18:25:14 UTC) #5
Tim Song
+yoz@ for easy_unlock_private.idl
5 years, 10 months ago (2015-01-27 18:25:35 UTC) #7
Yoyo Zhou
https://codereview.chromium.org/880603003/diff/40001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/880603003/diff/40001/chrome/common/extensions/api/easy_unlock_private.idl#newcode146 chrome/common/extensions/api/easy_unlock_private.idl:146: // Whether to check if the remote device is ...
5 years, 10 months ago (2015-01-27 20:41:55 UTC) #8
Tim Song
https://codereview.chromium.org/880603003/diff/40001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/880603003/diff/40001/chrome/common/extensions/api/easy_unlock_private.idl#newcode146 chrome/common/extensions/api/easy_unlock_private.idl:146: // Whether to check if the remote device is ...
5 years, 10 months ago (2015-01-27 20:52:33 UTC) #9
Yoyo Zhou
LGTM https://codereview.chromium.org/880603003/diff/80001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/880603003/diff/80001/chrome/common/extensions/api/easy_unlock_private.idl#newcode148 chrome/common/extensions/api/easy_unlock_private.idl:148: boolean checkCloseProximity; Sorry, actually, should this be called ...
5 years, 10 months ago (2015-01-27 21:07:50 UTC) #10
Tim Song
https://codereview.chromium.org/880603003/diff/80001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/880603003/diff/80001/chrome/common/extensions/api/easy_unlock_private.idl#newcode148 chrome/common/extensions/api/easy_unlock_private.idl:148: boolean checkCloseProximity; On 2015/01/27 21:07:50, Yoyo Zhou wrote: > ...
5 years, 10 months ago (2015-01-27 22:45:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880603003/100001
5 years, 10 months ago (2015-01-27 23:56:50 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-01-28 00:01:04 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 00:02:14 UTC) #15
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/e84f9035d530e39753dda03ec65076390ba88d72
Cr-Commit-Position: refs/heads/master@{#313409}

Powered by Google App Engine
This is Rietveld 408576698