Clean up pref state in the wake of removing the omnibox watcher.

Clean up pref state in the wake of removing the omnibox watcher.

BUG=451173
R=robertshield@chromium.org

Committed: https://crrev.com/4c0120a39f67fa867353f03e1f5baea13ca56646
Cr-Commit-Position: refs/heads/master@{#313347}

[robertshield, 2015-01-27 14:12:02]

LGTM, just nits

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
File
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
(right):

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:138:
IncidentType::OMNIBOX_INTERACTION,  // TODO(grt): remove in M44.
Reference bug with milestone?

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:142:
// any changes since notifications are sent for pref dict modifications.
is this a performance concern or a functional one? I think the approach here is
correct either way, but if it's a functional then it one would be nice to spell
it out for future readers.

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
File
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
(right):

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc:982:
incidents_sent->SetWithoutPathExpansion("4", type_dict);  // omnibox
s/"4"/IntToString(OMNIBOX_INTERACTION)/ here and below?

[grt (UTC plus 2), 2015-01-27 18:33:07]

Thanks.

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
File
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
(right):

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:138:
IncidentType::OMNIBOX_INTERACTION,  // TODO(grt): remove in M44.
On 2015/01/27 14:12:02, robertshield wrote:
> Reference bug with milestone?

Done.

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:142:
// any changes since notifications are sent for pref dict modifications.
On 2015/01/27 14:12:02, robertshield wrote:
> is this a performance concern or a functional one? I think the approach here
is
> correct either way, but if it's a functional then it one would be nice to
spell
> it out for future readers.

Done.

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
File
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
(right):

https://codereview.chromium.org/880603002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc:982:
incidents_sent->SetWithoutPathExpansion("4", type_dict);  // omnibox
On 2015/01/27 14:12:02, robertshield wrote:
> s/"4"/IntToString(OMNIBOX_INTERACTION)/ here and below?

Done.

[grt (UTC plus 2), 2015-01-27 18:33:10]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2015-01-27 18:34:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880603002/20001

[commit-bot: I haz the power, 2015-01-27 19:47:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 19:47:49]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[grt (UTC plus 2), 2015-01-27 19:50:13]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2015-01-27 19:50:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880603002/20001

[commit-bot: I haz the power, 2015-01-27 19:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 19:51:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[grt (UTC plus 2), 2015-01-27 20:28:34]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2015-01-27 20:29:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/880603002/20001

[commit-bot: I haz the power, 2015-01-27 20:34:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-27 20:35:42]

Patchset 2 (id:??) landed as
https://crrev.com/4c0120a39f67fa867353f03e1f5baea13ca56646
Cr-Commit-Position: refs/heads/master@{#313347}