Issue 880593003: Move the CustomElementDefinition from ElementRareData to Element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 880593003: Move the CustomElementDefinition from ElementRareData to Element. (Closed)

Created:
5 years, 10 months ago by esprehn

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Move the CustomElementDefinition from ElementRareData to Element. In Sky almost every element is a custom element, so this just bloats all elements by having it in the rare data structure. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6dc335d700f18aea073d3ad64fdec225634c11cd

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -13 lines)			Patch
M	sky/engine/core/dom/Element.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download
M	sky/engine/core/dom/ElementRareData.h	View	1	3 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/dom/ElementRareData.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

esprehn

5 years, 10 months ago (2015-01-26 21:15:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6dc335d700f18aea073d3ad64fdec225634c11cd (presubmit successful).