Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 880593003: Move the CustomElementDefinition from ElementRareData to Element. (Closed)

Created:
5 years, 10 months ago by esprehn
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move the CustomElementDefinition from ElementRareData to Element. In Sky almost every element is a custom element, so this just bloats all elements by having it in the rare data structure. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6dc335d700f18aea073d3ad64fdec225634c11cd

Patch Set 1 #

Patch Set 2 : Fix compile assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M sky/engine/core/dom/Element.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 1 chunk +3 lines, -7 lines 0 comments Download
M sky/engine/core/dom/ElementRareData.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/ElementRareData.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 10 months ago (2015-01-26 21:02:39 UTC) #2
esprehn
5 years, 10 months ago (2015-01-26 21:15:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6dc335d700f18aea073d3ad64fdec225634c11cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698