Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 880593002: [MemSheriff] Disable two tests which are flaky by design. (Closed)

Created:
5 years, 10 months ago by earthdok
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MemSheriff] Disable two tests which are flaky by design. Previously only disabled on Win. BUG=396393, 396386 TBR=jamesr@chromium.org NOTRY=true Committed: https://crrev.com/1d4c7f2b5dfe47e6fd8ed25068e126ec8584b91c Cr-Commit-Position: refs/heads/master@{#313086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M third_party/mojo/src/mojo/edk/system/message_pipe_dispatcher_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/simple_dispatcher_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
earthdok
5 years, 10 months ago (2015-01-26 17:36:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880593002/1
5 years, 10 months ago (2015-01-26 17:36:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-26 17:39:23 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1d4c7f2b5dfe47e6fd8ed25068e126ec8584b91c Cr-Commit-Position: refs/heads/master@{#313086}
5 years, 10 months ago (2015-01-26 17:42:38 UTC) #6
jam
these source files are copied from the mojo (github) repo. so they'll need to be ...
5 years, 10 months ago (2015-01-26 17:49:06 UTC) #7
earthdok
On 2015/01/26 17:49:06, jam wrote: > these source files are copied from the mojo (github) ...
5 years, 10 months ago (2015-01-26 17:57:44 UTC) #8
jam
On 2015/01/26 17:57:44, earthdok wrote: > On 2015/01/26 17:49:06, jam wrote: > > these source ...
5 years, 10 months ago (2015-01-26 18:00:43 UTC) #9
earthdok
5 years, 10 months ago (2015-01-26 18:09:54 UTC) #10
Message was sent while issue was closed.
On 2015/01/26 18:00:43, jam wrote:
> we will run into the same issue as well though: the bot will turn red and the
> fix will be in another repo, one which almost all chromium devs don't have
> access to.
> 
> if we really care about running them under msan, those bots should be setup on
> the mojo waterfall (they have asan there already btw)

bug filed https://code.google.com/p/chromium/issues/detail?id=452090
if anyone wants to take on adding an MSan bot for mojo, I'll be happy to help

Powered by Google App Engine
This is Rietveld 408576698