Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880573007: Re-attach renderer for progress/meter when author shadow is allowed. (Closed)

Created:
5 years, 10 months ago by rune
Modified:
5 years, 10 months ago
Reviewers:
tkent, hayato
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Re-attach renderer for progress/meter when author shadow is allowed. If the author shadow dom is added to progress/meter after the UA shadow dom renderers have been created, the UA shadow dom renderers will stick. Fixed by doing a lazyReattachIfAttached for the progress/meter host which were already done for input elements, for instance. Fixes flaky tests for progress/meter. R=tkent@chromium.org BUG=432129 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -51 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -47 lines 0 comments Download
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadowdom-for-meter-redistribute.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadowdom-for-meter-redistribute-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadowdom-for-progress-redistribute.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadowdom-for-progress-redistribute-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMeterElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLProgressElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rune
PTAL
5 years, 10 months ago (2015-02-06 19:05:43 UTC) #1
tkent
lgtm
5 years, 10 months ago (2015-02-08 23:50:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/880573007/1
5 years, 10 months ago (2015-02-08 23:50:37 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-08 23:54:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189764

Powered by Google App Engine
This is Rietveld 408576698